Skip to content

[browser][coreCLR] JitInfoIsPopulated #123350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelsavara merged 17 commits into from
Jan 22, 2026
Merged

[browser][coreCLR] JitInfoIsPopulated #123350

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d49c860
wip
pavelsavara Jan 19, 2026
ce0a4f0
case
pavelsavara Jan 19, 2026
60f5e0f
Merge branch 'main' into browser_clr_fix_JitInfoIsPopulated
pavelsavara Jan 19, 2026
009295b
revert unnecessary changes
pavelsavara Jan 19, 2026
99379f6
Merge branch 'main' into browser_clr_fix_JitInfoIsPopulated
pavelsavara Jan 20, 2026
c7a5507
feedback
pavelsavara Jan 20, 2026
3ba27e0
Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System…
pavelsavara Jan 20, 2026
d9aa332
Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System…
pavelsavara Jan 20, 2026
6aa038f
Merge branch 'main' into browser_clr_fix_JitInfoIsPopulated
pavelsavara Jan 20, 2026
b45157f
Merge branch 'main' into browser_clr_fix_JitInfoIsPopulated
pavelsavara Jan 21, 2026
96842a4
Merge branch 'main' into browser_clr_fix_JitInfoIsPopulated
pavelsavara Jan 21, 2026
fa5ac68
more testing
pavelsavara Jan 21, 2026
1f7ff44
Merge branch 'main' into browser_clr_fix_JitInfoIsPopulated
pavelsavara Jan 21, 2026
e3e402d
back
pavelsavara Jan 21, 2026
85bf464
Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System…
pavelsavara Jan 21, 2026
2810984
Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System…
pavelsavara Jan 21, 2026
d2cb8e1
Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System…
jkotas Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ public static partial class PlatformDetection
public static bool IsNetCore => Environment.Version.Major >= 5 || RuntimeInformation.FrameworkDescription.StartsWith(".NET Core", StringComparison.OrdinalIgnoreCase);
public static bool IsMonoRuntime => Type.GetType("Mono.RuntimeStructs") != null;
public static bool IsNotMonoRuntime => !IsMonoRuntime;
public static bool IsInterpreter => IsMonoInterpreter || IsCoreClrInterpreter;
public static bool IsNotInterpreter => !IsInterpreter;
public static bool IsMonoInterpreter => GetIsRunningOnMonoInterpreter();
public static bool IsNotMonoInterpreter => !IsMonoInterpreter;
public static bool IsMonoAOT => Environment.GetEnvironmentVariable("MONO_AOT_MODE") == "aot";
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/JitInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public void JitInfoIsPopulated()
long afterCompiledILBytes = System.Runtime.JitInfo.GetCompiledILBytes();
long afterCompiledMethodCount = System.Runtime.JitInfo.GetCompiledMethodCount();

if (PlatformDetection.IsMonoInterpreter || PlatformDetection.IsMonoAOT || PlatformDetection.IsReadyToRunCompiled)
if (PlatformDetection.IsMonoInterpreter || PlatformDetection.IsCoreClrInterpreter || PlatformDetection.IsMonoAOT || PlatformDetection.IsReadyToRunCompiled)
Comment thread
pavelsavara marked this conversation as resolved.
Outdated
Comment thread
pavelsavara marked this conversation as resolved.
Outdated
{
// JitInfo metrics may be 0 in AOT scenarios
Assert.True(beforeCompilationTime >= TimeSpan.Zero, $"Compilation time not greater or equal to 0! ({beforeCompilationTime})");
Expand All @@ -65,7 +65,7 @@ public void JitInfoIsPopulated()
Assert.True(beforeCompiledMethodCount > 0, $"Compiled method count not greater than 0! ({beforeCompiledMethodCount})");
}

if (PlatformDetection.IsMonoInterpreter)
if (PlatformDetection.IsMonoInterpreter || PlatformDetection.IsCoreClrInterpreter)
Comment thread
pavelsavara marked this conversation as resolved.
Outdated
Comment thread
pavelsavara marked this conversation as resolved.
Outdated
{
// Before and after will most likely be the same with the interpreter
Assert.True(afterCompilationTime >= beforeCompilationTime, $"CompilationTime: after not greater than before! (after: {afterCompilationTime}, before: {beforeCompilationTime})");
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Text.Json/tests/System.Text.Json.Tests/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
using System;
using Xunit;

[assembly: ActiveIssue("Interpreter with debug runtime can be very slow", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter), nameof(PlatformDetection.IsDebugRuntime))]
[assembly: ActiveIssue("Interpreter with debug runtime can be very slow", typeof(PlatformDetection), nameof(PlatformDetection.IsInterpreter), nameof(PlatformDetection.IsDebugRuntime))]
2 changes: 1 addition & 1 deletion src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonReaderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1649,7 +1649,7 @@ public static void TestPartialJsonReaderSlicesSpecialNumbers(TestCaseType type,
[InlineData(512)]
public static void TestDepth(int depth)
{
if (PlatformDetection.IsMonoInterpreter && depth >= 256)
if (PlatformDetection.IsInterpreter && depth >= 256)
{
throw new SkipTestException("Takes very long to run on interpreter.");
}
Expand Down