Skip to content

[browser][coreCLR] fix nArgsSize for RuntimeMethodHandle_InvokeMethod #122350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelsavara merged 2 commits into from
Dec 9, 2025
Merged

[browser][coreCLR] fix nArgsSize for RuntimeMethodHandle_InvokeMethod #122350

pavelsavara merged 2 commits into from
Dec 9, 2025

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 9, 2025 •
edited
Loading

Fixes #122343

@pavelsavara pavelsavara added this to the 11.0.0 milestone Dec 9, 2025
@pavelsavara pavelsavara self-assigned this Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 18:04
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm area-CodeGen-Interpreter-coreclr labels Dec 9, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Dec 9, 2025

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

radekdoulik
radekdoulik reviewed Dec 9, 2025
View reviewed changes
radekdoulik
radekdoulik approved these changes Dec 9, 2025
View reviewed changes
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

janvorli
janvorli approved these changes Dec 9, 2025
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@pavelsavara pavelsavara enabled auto-merge (squash) December 9, 2025 18:33
Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@pavelsavara pavelsavara merged commit 1ebc242 into dotnet:main Dec 9, 2025
100 checks passed
@pavelsavara pavelsavara deleted the nArgsSize branch December 9, 2025 20:36
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 9, 2025
Closed
@maestro-local-dev maestro-local-dev bot mentioned this pull request Dec 10, 2025
Closed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@radekdoulik radekdoulik radekdoulik approved these changes

@janvorli janvorli janvorli approved these changes

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-CodeGen-Interpreter-coreclr os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

[browser][coreCLR] - Reflection.Pointer unboxing is broken

3 participants

@pavelsavara @radekdoulik @janvorli