Re-Enable JIT calls for Wasm Target in Crossgen #122334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al JIT, since the RyuJIT backend is now emitting Wasm
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the temporary stubbing behavior for WebAssembly (Wasm32) target in crossgen compilation. Previously, the CompileWasmStub method generated a minimal stub instead of performing actual JIT compilation. Now, the JIT is invoked normally for Wasm targets to enable proper code generation for object files.
Key changes:
- Removed the
CompileWasmStubmethod that generated placeholder WebAssembly bytecode - Simplified
CompileMethodInternalto use JIT compilation uniformly across all architectures including Wasm32 - Removed architecture-specific branching logic
This was referenced Dec 9, 2025
MichalStrehovsky
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the behavior from #122111 which stubs out a method instead of calling the JIT for the crossgen Wasm target. Now, the JIT will be invoked as normal so that the output of method codegen can be placed in a simple object file.
Output code currently won't run (I tried this) because we aren't yet emitting a correct local count at the beginning of compiled methods.