Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 9, 2025

The WASM codegen was missing handlers for GT_NO_OP and GT_NOP node types in CodeGen::genCodeForTreeNode, causing failures when these nodes were encountered during code generation.

Changes

  • GT_NOP: Added case that breaks immediately (marker-only node, emits no code)
  • GT_NO_OP: Added case that emits INS_nop instruction (non-deletable NOP)

Implementation matches existing patterns across x86, ARM, and RISC-V architectures.

case GT_NOP:
    break;

case GT_NO_OP:
    instGen(INS_nop);
    break;
Original prompt

This section details on the original issue you should resolve

<issue_title>[RyuJIT Wasm] Missing handler for GT_NO_OP</issue_title>
<issue_description>CodeGen::genCodeForTreeNode needs to be updated with a case for GT_NO_OP that emits an INS_nop. It also needs a case for GT_NOP that does nothing.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI assigned Copilot and kg Dec 9, 2025
@kg kg added arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 9, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot AI changed the title [WIP] Add handler for GT_NO_OP in CodeGen [RyuJIT WASM] Add GT_NO_OP and GT_NOP handlers to genCodeForTreeNode Dec 9, 2025
Copilot AI requested a review from kg December 9, 2025 02:30
Copilot finished work on behalf of kg December 9, 2025 02:30
@kg kg marked this pull request as ready for review December 9, 2025 04:22
Copilot AI review requested due to automatic review settings December 9, 2025 04:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RyuJIT Wasm] Missing handler for GT_NO_OP

4 participants