Skip to content

Fix YieldProcessorMeasurement running continuously due to timestamp truncation #122293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agocke merged 3 commits into from
Dec 8, 2025
Merged

Fix YieldProcessorMeasurement running continuously due to timestamp truncation #122293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cb5e68
Initial plan
Copilot Dec 8, 2025
32308b1
Fix YieldProcessorMeasurement high CPU bug by removing incorrect cast
Copilot Dec 8, 2025
185a090
Add parentheses to clarify operator precedence in time comparison
Copilot Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/coreclr/vm/yieldprocessornormalizedshared.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ void YieldProcessorNormalization::PerformMeasurement()
double latestNsPerYield;
if (s_normalizationState == NormalizationState::Initialized)
{
if (minipal_lowres_ticks() - s_previousNormalizationTimeMs < MeasurementPeriodMs)
if ((minipal_lowres_ticks() - s_previousNormalizationTimeMs) < MeasurementPeriodMs)
{
return;
}
Expand Down Expand Up @@ -203,7 +203,7 @@ void YieldProcessorNormalization::PerformMeasurement()

GCHeapUtilities::GetGCHeap()->SetYieldProcessorScalingFactor((float)yieldsPerNormalizedYield);

s_previousNormalizationTimeMs = (unsigned int)minipal_lowres_ticks();
s_previousNormalizationTimeMs = minipal_lowres_ticks();
s_normalizationState = NormalizationState::Initialized;
s_isMeasurementScheduled = false;
}
Expand All @@ -222,7 +222,7 @@ void YieldProcessorNormalization::ScheduleMeasurementIfNecessary()
NormalizationState normalizationState = VolatileLoadWithoutBarrier(&s_normalizationState);
if (normalizationState == NormalizationState::Initialized)
{
if (minipal_lowres_ticks() - s_previousNormalizationTimeMs < MeasurementPeriodMs)
if ((minipal_lowres_ticks() - s_previousNormalizationTimeMs) < MeasurementPeriodMs)
{
return;
}
Expand Down
Loading