JIT: Check for OperConsumesFlags in new OptimizeCallIndirectTargetEvaluation
#122292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider these to interfere with all other nodes.
This reverts commit 8bbdefb.
github-actions
bot
added
the
area-CodeGen-coreclr
Member
Author
|
PTAL @dotnet/jit-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #122289 by adding a check for nodes that consume CPU flags before reordering them in the OptimizeCallIndirectTargetEvaluation function. The fix prevents incorrect code generation that could occur when nodes consuming flags are reordered relative to the nodes that set those flags.
- Adds
OperConsumesFlags()check to prevent unsafe node reordering - Uses a localized fix rather than a more conservative approach that caused regressions
- Follows existing patterns used in similar reordering checks in the codebase
AndyAyersMS
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #122289
Didn't add the regression test because it will be broken by #122023.
I also tried adding conservative handling to
SideEffectSetfor the situation (see earlier commit), but that introduced a lot of regressions in cases where the reordering is ok, so I went with a more localized fix here.