[browser] Set WasmGenerateAppBundle=false for browser-wasm to skip run args override #122259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mitigates a regression from PR #120330 by setting WasmGenerateAppBundle=false for browser-wasm projects. This prevents the automatic generation of run arguments that would otherwise be set when WasmGenerateAppBundle is true (as configured on lines 241-249 of the same file).
Key Changes:
- Added a new property assignment that sets
WasmGenerateAppBundle=falsespecifically whenRuntimeIdentifierisbrowser-wasm - This assignment is placed before the existing general rule (line 178) to ensure it takes precedence
pavelsavara
approved these changes
Dec 6, 2025
This was referenced Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #120330
Mitigates #122255
In the previous I have removed logic for "Generate Wasm AppBundle" from browser specific targets and removed setting the
WasmGenerateAppBundle=false, because it should not do anything for browser. In the common targets we have a logic to compute run arguments, working dir and command. IfWasmGenerateAppBundle=truethis logic kicks in.