Skip to content

Conversation

@pavelsavara
Copy link
Member

Contributes to #120703

@pavelsavara pavelsavara added this to the 11.0.0 milestone Dec 5, 2025
@pavelsavara pavelsavara self-assigned this Dec 5, 2025
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Dec 5, 2025
@pavelsavara pavelsavara marked this pull request as ready for review December 8, 2025 09:14
@pavelsavara pavelsavara requested a review from lewing as a code owner December 8, 2025 09:14
Copilot AI review requested due to automatic review settings December 8, 2025 09:14
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames internal JavaScript import functions from snake_case to camelCase convention, improving naming consistency across the browser WebAssembly runtime. The changes affect the TypeScript export definitions and all corresponding C# JSImport attribute declarations.

  • Updates TypeScript exports in exports-internal.ts to use camelCase naming
  • Updates all C# JSImport declarations to match the new TypeScript export names
  • Covers interop functions, WebSocket operations, and HTTP handler functions

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/mono/browser/runtime/exports-internal.ts Renames TypeScript exports from snake_case to camelCase (e.g., get_propertygetProperty, ws_wasm_createwsCreate, http_wasm_fetchhttpFetch)
src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/Utils.cs Updates test utility JSImport declarations to use new camelCase names for setProperty and getProperty
src/libraries/System.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptImports.Generated.cs Updates all core JavaScript interop JSImport declarations to use camelCase names
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserInterop.cs Updates WebSocket-related JSImport declarations to use new camelCase names (e.g., wsCreate, wsOpen, wsSend)
src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpInterop.cs Updates HTTP handler JSImport declarations to use new camelCase names (e.g., httpFetch, httpSupportsStreamingRequest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants