Fix return statement in X509ResourceClient instrumentation #122226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AssetDownloadStop event did not contain the downloaded payload size
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the X509ResourceClient instrumentation where the AssetDownloadStop event was not reporting the actual downloaded payload size on successful downloads. The issue occurred because the return statement bypassed the assignment to the ret variable that tracks the downloaded bytes.
- Fixed return statement to assign result to
retvariable before returning - Ensures the
finallyblock can report the correct downloaded payload size to the AssetDownloadStop event
MihaZupan
approved these changes
Dec 5, 2025
wfurt
approved these changes
Dec 5, 2025
rzikm
added
area-System.Security
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AssetDownloadStop event did not contain the downloaded payload size