Fix SVE2 API for Odd/Even methods #122173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
a74nh
reviewed
Dec 4, 2025
...raries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.PlatformNotSupported.cs
Show resolved
Hide resolved
a74nh
approved these changes
Dec 4, 2025
Contributor
a74nh
left a comment
a74nh
left a comment
There was a problem hiding this comment.
Assuming ShiftLeftLogicalWideningEven and ShiftLeftLogicalWideningOdd changes are reverted.
All other API changes match what was mentioned in the issue. Plus, when running my script I see only reductions in diffs between reviewed vs implemented.
So LGTM.
This was referenced Dec 4, 2025
Open
Rename `shiftAmount` back to `count`.
tannergooding
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121961.
Rename argument names for the following methods:
AddCarryWideningEven/AddCarryWideningOdd:op1, op2, op3=>left, right, carry.SubtractBorrowWideningEven/SubtractBorrowWideningOdd:op1, op2, op3=>left, right, borrow.ShiftLeftLogicalWideningEven/ShiftLeftLogicalWideningOdd:value, count=>value, shiftAmount.AddWideningEvenOdd:left, right=>leftEven, rightOdd.SubtractWideningEvenOdd:left, right=>leftEven, rightOdd.SubtractWideningOddEven:left, right=>leftOdd, rightEven.InterleavingXorEvenOdd:odd, left, right=>odd, leftEven, rightOdd.InterleavingXorOddEven:even, left, right=>even, leftOdd, rightEven.@dotnet/arm64-contrib @a74nh