-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Increase HostActivation test hang dump timeout to 8 minutes for OSX CI #122171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: agocke <[email protected]>
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR increases the hang dump timeout for host installer tests from 5 minutes to 8 minutes to accommodate slower CI environments, particularly on OSX where HostActivation tests were being incorrectly flagged as hangs despite making steady progress.
Key Changes:
- Increased
--hangdump-timeoutparameter from5mto8min test runner configuration
|
This happened to coincide with mac queues coming back online, and has suddenly stopped reproducing. My thinking might just be the heavy overloading caused these tests to start timing out. We may not need to change anything |
|
Nope still happening occasionally, we should just bump the timeout |
|
I filed microsoft/testfx#7060 On macOS, the That is why we started hitting this after the switch to xunit v3 and only on macOS (and only on the one where we run Debug), not other platforms (even in Debug). |
HostActivation tests are hitting the 5-minute hang dump timeout on OSX CI despite making steady progress. Tests complete in ~2 minutes locally but CI environments run 2x slower.
Changes:
--hangdump-timeoutfrom5mto8minsrc/installer/tests/Directory.Build.propsThis provides adequate headroom for slower CI machines while still catching actual hangs.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.