Skip to content

Conversation

@huoyaoyuan
Copy link
Member

Simplifies resource loading and get rid of module loading.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thanks!

@janvorli Any concerns about this cleanup?

@janvorli
Copy link
Member

janvorli commented Dec 4, 2025

@jkotas I don't have any concerns w.r.t. this change.

@jkotas
Copy link
Member

jkotas commented Dec 4, 2025

I have done a pass over all remaining mscorrc occurrences. There are a few that can use cleanup:
src\libraries\System.Private.CoreLib\src\System\TypeLoadException.cs(74):// and ResourceId (mscorrc.dll). This allows customization of the -> rename to just mscorrc?
src\tests\Common\CLRTest.Execute.Batch.targets(301):copy %CORE_ROOT%\mscorrc.dll %LinkBin% > nul 2> nul -> delete

@jkotas jkotas merged commit 8957509 into dotnet:main Dec 5, 2025
143 of 148 checks passed
@jkotas
Copy link
Member

jkotas commented Dec 5, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants