-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add missing helix-platforms.yml import to pipelines using helix variable aliases #122075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: agocke <[email protected]>
agocke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please address comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes unresolved variable reference errors for helix platform aliases (e.g., $(helix_macos_arm64)) that were introduced in PR #121373 but only partially integrated into the pipeline infrastructure.
Key changes:
- Adds the missing
helix-platforms.ymltemplate import to 48 pipeline files - Ensures all pipelines using
helix-queues-setup.ymlorjit-outerloop-pipeline.ymlcan resolve helix platform variable aliases - Maintains consistent YAML formatting with appropriate blank lines between sections
Reviewed changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/runtimelab.yml | Added helix-platforms.yml import for runtimelab pipeline |
| eng/pipelines/runtimelab-official.yml | Added helix-platforms.yml import for official runtimelab builds |
| eng/pipelines/runtime-sanitized.yml | Added helix-platforms.yml import for sanitized runtime pipeline |
| eng/pipelines/runtime-llvm.yml | Added helix-platforms.yml import for LLVM runtime pipeline |
| eng/pipelines/runtime-extra-platforms.yml | Added helix-platforms.yml import for extra platforms pipeline |
| eng/pipelines/runtime-community.yml | Added helix-platforms.yml import for community runtime pipeline |
| eng/pipelines/runtime-cet.yml | Added helix-platforms.yml import for CET runtime pipeline |
| eng/pipelines/libraries/variables.yml | Added helix-platforms.yml import to shared libraries variables (affects outerloop.yml and outerloop-mono.yml) |
| eng/pipelines/coreclr/tieringtest.yml | Added helix-platforms.yml import for tiering test pipeline |
| eng/pipelines/coreclr/superpmi-diffs.yml | Added helix-platforms.yml import for SuperPMI diffs pipeline |
| eng/pipelines/coreclr/superpmi-asmdiffs-checked-release.yml | Added helix-platforms.yml import for SuperPMI asmdiffs pipeline |
| eng/pipelines/coreclr/runincontext.yml | Added helix-platforms.yml import for runincontext pipeline |
| eng/pipelines/coreclr/release-tests.yml | Added helix-platforms.yml import for release tests pipeline |
| eng/pipelines/coreclr/r2r.yml | Added helix-platforms.yml import for R2R pipeline |
| eng/pipelines/coreclr/r2r-extra.yml | Added helix-platforms.yml import for extra R2R pipeline |
| eng/pipelines/coreclr/pgostress.yml | Added helix-platforms.yml import for PGO stress pipeline |
| eng/pipelines/coreclr/pgo.yml | Added helix-platforms.yml import for PGO pipeline |
| eng/pipelines/coreclr/libraries-pgo.yml | Added helix-platforms.yml import for libraries PGO pipeline |
| eng/pipelines/coreclr/libraries-jitstressregs.yml | Added helix-platforms.yml import for libraries jitstressregs pipeline |
| eng/pipelines/coreclr/libraries-jitstress2-jitstressregs.yml | Added helix-platforms.yml import for libraries jitstress2-jitstressregs pipeline |
| eng/pipelines/coreclr/libraries-jitstress.yml | Added helix-platforms.yml import for libraries jitstress pipeline |
| eng/pipelines/coreclr/libraries-jitstress-random.yml | Added helix-platforms.yml import for libraries jitstress-random pipeline |
| eng/pipelines/coreclr/libraries-gcstress0x3-gcstress0xc.yml | Added helix-platforms.yml import for libraries gcstress pipeline |
| eng/pipelines/coreclr/libraries-gcstress-extra.yml | Added helix-platforms.yml import for libraries gcstress-extra pipeline |
| eng/pipelines/coreclr/jitstressregs.yml | Added helix-platforms.yml import for jitstressregs pipeline |
| eng/pipelines/coreclr/jitstressregs-x86.yml | Added helix-platforms.yml import for jitstressregs-x86 pipeline |
| eng/pipelines/coreclr/jitstress2-jitstressregs.yml | Added helix-platforms.yml import for jitstress2-jitstressregs pipeline |
| eng/pipelines/coreclr/jitstress.yml | Added helix-platforms.yml import for jitstress pipeline |
| eng/pipelines/coreclr/jitstress-random.yml | Added helix-platforms.yml import for jitstress-random pipeline |
| eng/pipelines/coreclr/jitstress-isas-x86.yml | Added helix-platforms.yml import for jitstress-isas-x86 pipeline |
| eng/pipelines/coreclr/jitstress-isas-avx512.yml | Added helix-platforms.yml import for jitstress-isas-avx512 pipeline |
| eng/pipelines/coreclr/jitstress-isas-arm.yml | Added helix-platforms.yml import for jitstress-isas-arm pipeline |
| eng/pipelines/coreclr/jit-experimental.yml | Added helix-platforms.yml import for JIT experimental pipeline |
| eng/pipelines/coreclr/jit-cfg.yml | Added helix-platforms.yml import for JIT CFG pipeline |
| eng/pipelines/coreclr/interpreter.yml | Added helix-platforms.yml import for interpreter pipeline |
| eng/pipelines/coreclr/ilasm.yml | Added helix-platforms.yml import for ilasm pipeline |
| eng/pipelines/coreclr/hardware-intrinsics.yml | Added helix-platforms.yml import for hardware intrinsics pipeline |
| eng/pipelines/coreclr/gcstress0x3-gcstress0xc.yml | Added helix-platforms.yml import for gcstress pipeline |
| eng/pipelines/coreclr/gcstress-extra.yml | Added helix-platforms.yml import for gcstress-extra pipeline |
| eng/pipelines/coreclr/gc-standalone.yml | Added helix-platforms.yml import for standalone GC pipeline |
| eng/pipelines/coreclr/gc-simulator.yml | Added helix-platforms.yml import for GC simulator pipeline |
| eng/pipelines/coreclr/gc-longrunning.yml | Added helix-platforms.yml import for long-running GC pipeline |
| eng/pipelines/coreclr/exploratory.yml | Added helix-platforms.yml import for exploratory pipeline |
| eng/pipelines/coreclr/crossgen2.yml | Added helix-platforms.yml import for crossgen2 pipeline |
| eng/pipelines/coreclr/crossgen2-outerloop.yml | Added helix-platforms.yml import for crossgen2 outerloop pipeline |
| eng/pipelines/coreclr/crossgen2-gcstress.yml | Added helix-platforms.yml import for crossgen2 gcstress pipeline |
| eng/pipelines/coreclr/crossgen2-composite.yml | Added helix-platforms.yml import for crossgen2 composite pipeline |
| eng/pipelines/coreclr/ci.yml | Added helix-platforms.yml import for CoreCLR CI pipeline |
…al pipeline files Co-authored-by: agocke <[email protected]>
|
@jkoritzinsky, @agocke, please review this PR. This issue is failing many JIT pipelines. |
|
/azp run runtime-coreclr ilasm |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp list |
|
/azp run runtime-cet |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Note: the mac Helix queue is down, so after this is merged the pipelines will still fail, but because there are no machines |
|
Merged -- all of the failures were timeouts or not in the mac queues, which is the expected behavior. |
helix-platforms.ymlimport to coreclr pipelines using helix-queues-setup or jit-outerloop-pipeline templateshelix-platforms.ymlimport to libraries pipelines (directly to pipeline files, not shared template)helix-platforms.ymlimport to other pipelines✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.