Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 1, 2025

  • Add helix-platforms.yml import to coreclr pipelines using helix-queues-setup or jit-outerloop-pipeline templates
    • ci.yml
    • crossgen2-composite.yml
    • crossgen2-gcstress.yml
    • crossgen2-outerloop.yml
    • crossgen2.yml
    • exploratory.yml
    • gc-longrunning.yml
    • gc-simulator.yml
    • gc-standalone.yml
    • gcstress-extra.yml
    • gcstress0x3-gcstress0xc.yml
    • hardware-intrinsics.yml
    • ilasm.yml
    • interpreter.yml
    • jit-cfg.yml
    • jit-experimental.yml
    • jitstress-isas-arm.yml
    • jitstress-isas-avx512.yml
    • jitstress-isas-x86.yml
    • jitstress-random.yml
    • jitstress.yml
    • jitstress2-jitstressregs.yml
    • jitstressregs-x86.yml
    • jitstressregs.yml
    • libraries-gcstress-extra.yml
    • libraries-gcstress0x3-gcstress0xc.yml
    • libraries-jitstress-random.yml
    • libraries-jitstress.yml
    • libraries-jitstress2-jitstressregs.yml
    • libraries-jitstressregs.yml
    • libraries-pgo.yml
    • pgo.yml
    • pgostress.yml
    • r2r-extra.yml
    • r2r.yml
    • release-tests.yml
    • runincontext.yml
    • superpmi-asmdiffs-checked-release.yml
    • superpmi-diffs.yml
    • tieringtest.yml
  • Add helix-platforms.yml import to libraries pipelines (directly to pipeline files, not shared template)
    • outerloop.yml
    • outerloop-mono.yml
  • Add helix-platforms.yml import to other pipelines
    • runtime-cet.yml
    • runtime-community.yml
    • runtime-extra-platforms.yml
    • runtime-llvm.yml
    • runtime-sanitized.yml
    • runtimelab-official.yml
    • runtimelab.yml
  • Run code review (no issues found)
  • Run security check (no issues found)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix Helix API entry for $(helix_macos_arm64) Add missing helix-platforms.yml import to pipelines using helix variable aliases Dec 1, 2025
Copilot AI requested a review from agocke December 1, 2025 19:15
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Please address comment

@agocke agocke marked this pull request as ready for review December 1, 2025 22:49
Copilot AI review requested due to automatic review settings December 1, 2025 22:49
@agocke agocke requested a review from EgorBo December 1, 2025 22:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes unresolved variable reference errors for helix platform aliases (e.g., $(helix_macos_arm64)) that were introduced in PR #121373 but only partially integrated into the pipeline infrastructure.

Key changes:

  • Adds the missing helix-platforms.yml template import to 48 pipeline files
  • Ensures all pipelines using helix-queues-setup.yml or jit-outerloop-pipeline.yml can resolve helix platform variable aliases
  • Maintains consistent YAML formatting with appropriate blank lines between sections

Reviewed changes

Copilot reviewed 48 out of 48 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/pipelines/runtimelab.yml Added helix-platforms.yml import for runtimelab pipeline
eng/pipelines/runtimelab-official.yml Added helix-platforms.yml import for official runtimelab builds
eng/pipelines/runtime-sanitized.yml Added helix-platforms.yml import for sanitized runtime pipeline
eng/pipelines/runtime-llvm.yml Added helix-platforms.yml import for LLVM runtime pipeline
eng/pipelines/runtime-extra-platforms.yml Added helix-platforms.yml import for extra platforms pipeline
eng/pipelines/runtime-community.yml Added helix-platforms.yml import for community runtime pipeline
eng/pipelines/runtime-cet.yml Added helix-platforms.yml import for CET runtime pipeline
eng/pipelines/libraries/variables.yml Added helix-platforms.yml import to shared libraries variables (affects outerloop.yml and outerloop-mono.yml)
eng/pipelines/coreclr/tieringtest.yml Added helix-platforms.yml import for tiering test pipeline
eng/pipelines/coreclr/superpmi-diffs.yml Added helix-platforms.yml import for SuperPMI diffs pipeline
eng/pipelines/coreclr/superpmi-asmdiffs-checked-release.yml Added helix-platforms.yml import for SuperPMI asmdiffs pipeline
eng/pipelines/coreclr/runincontext.yml Added helix-platforms.yml import for runincontext pipeline
eng/pipelines/coreclr/release-tests.yml Added helix-platforms.yml import for release tests pipeline
eng/pipelines/coreclr/r2r.yml Added helix-platforms.yml import for R2R pipeline
eng/pipelines/coreclr/r2r-extra.yml Added helix-platforms.yml import for extra R2R pipeline
eng/pipelines/coreclr/pgostress.yml Added helix-platforms.yml import for PGO stress pipeline
eng/pipelines/coreclr/pgo.yml Added helix-platforms.yml import for PGO pipeline
eng/pipelines/coreclr/libraries-pgo.yml Added helix-platforms.yml import for libraries PGO pipeline
eng/pipelines/coreclr/libraries-jitstressregs.yml Added helix-platforms.yml import for libraries jitstressregs pipeline
eng/pipelines/coreclr/libraries-jitstress2-jitstressregs.yml Added helix-platforms.yml import for libraries jitstress2-jitstressregs pipeline
eng/pipelines/coreclr/libraries-jitstress.yml Added helix-platforms.yml import for libraries jitstress pipeline
eng/pipelines/coreclr/libraries-jitstress-random.yml Added helix-platforms.yml import for libraries jitstress-random pipeline
eng/pipelines/coreclr/libraries-gcstress0x3-gcstress0xc.yml Added helix-platforms.yml import for libraries gcstress pipeline
eng/pipelines/coreclr/libraries-gcstress-extra.yml Added helix-platforms.yml import for libraries gcstress-extra pipeline
eng/pipelines/coreclr/jitstressregs.yml Added helix-platforms.yml import for jitstressregs pipeline
eng/pipelines/coreclr/jitstressregs-x86.yml Added helix-platforms.yml import for jitstressregs-x86 pipeline
eng/pipelines/coreclr/jitstress2-jitstressregs.yml Added helix-platforms.yml import for jitstress2-jitstressregs pipeline
eng/pipelines/coreclr/jitstress.yml Added helix-platforms.yml import for jitstress pipeline
eng/pipelines/coreclr/jitstress-random.yml Added helix-platforms.yml import for jitstress-random pipeline
eng/pipelines/coreclr/jitstress-isas-x86.yml Added helix-platforms.yml import for jitstress-isas-x86 pipeline
eng/pipelines/coreclr/jitstress-isas-avx512.yml Added helix-platforms.yml import for jitstress-isas-avx512 pipeline
eng/pipelines/coreclr/jitstress-isas-arm.yml Added helix-platforms.yml import for jitstress-isas-arm pipeline
eng/pipelines/coreclr/jit-experimental.yml Added helix-platforms.yml import for JIT experimental pipeline
eng/pipelines/coreclr/jit-cfg.yml Added helix-platforms.yml import for JIT CFG pipeline
eng/pipelines/coreclr/interpreter.yml Added helix-platforms.yml import for interpreter pipeline
eng/pipelines/coreclr/ilasm.yml Added helix-platforms.yml import for ilasm pipeline
eng/pipelines/coreclr/hardware-intrinsics.yml Added helix-platforms.yml import for hardware intrinsics pipeline
eng/pipelines/coreclr/gcstress0x3-gcstress0xc.yml Added helix-platforms.yml import for gcstress pipeline
eng/pipelines/coreclr/gcstress-extra.yml Added helix-platforms.yml import for gcstress-extra pipeline
eng/pipelines/coreclr/gc-standalone.yml Added helix-platforms.yml import for standalone GC pipeline
eng/pipelines/coreclr/gc-simulator.yml Added helix-platforms.yml import for GC simulator pipeline
eng/pipelines/coreclr/gc-longrunning.yml Added helix-platforms.yml import for long-running GC pipeline
eng/pipelines/coreclr/exploratory.yml Added helix-platforms.yml import for exploratory pipeline
eng/pipelines/coreclr/crossgen2.yml Added helix-platforms.yml import for crossgen2 pipeline
eng/pipelines/coreclr/crossgen2-outerloop.yml Added helix-platforms.yml import for crossgen2 outerloop pipeline
eng/pipelines/coreclr/crossgen2-gcstress.yml Added helix-platforms.yml import for crossgen2 gcstress pipeline
eng/pipelines/coreclr/crossgen2-composite.yml Added helix-platforms.yml import for crossgen2 composite pipeline
eng/pipelines/coreclr/ci.yml Added helix-platforms.yml import for CoreCLR CI pipeline

@JulieLeeMSFT
Copy link
Member

@jkoritzinsky, @agocke, please review this PR. This issue is failing many JIT pipelines.

@agocke
Copy link
Member

agocke commented Dec 3, 2025

/azp run runtime-coreclr ilasm

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@agocke
Copy link
Member

agocke commented Dec 3, 2025

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@agocke
Copy link
Member

agocke commented Dec 3, 2025

/azp run runtime-cet

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agocke
Copy link
Member

agocke commented Dec 3, 2025

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agocke
Copy link
Member

agocke commented Dec 3, 2025

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agocke
Copy link
Member

agocke commented Dec 3, 2025

Note: the mac Helix queue is down, so after this is merged the pipelines will still fail, but because there are no machines

@agocke agocke merged commit 171a943 into main Dec 3, 2025
208 of 235 checks passed
@agocke agocke deleted the copilot/fix-helix-api-entry branch December 3, 2025 23:59
@agocke
Copy link
Member

agocke commented Dec 3, 2025

Merged -- all of the failures were timeouts or not in the mac queues, which is the expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants