Skip to content

Fix IndexOutOfRangeException in ILVerify for invalid exception handler offsets #122056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Fix IndexOutOfRangeException in ILVerify for invalid exception handler offsets #122056

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e724ee1
Initial plan
Copilot Nov 29, 2025
6f19ec1
Fix IndexOutOfRangeException in ILVerify for invalid exception handle…
Copilot Nov 29, 2025
56fd7e9
Add specific error types for invalid exception region offsets
Copilot Nov 30, 2025
d012c77
Add tests for invalid exception region offsets using -ERR ilasm flag
Copilot Nov 30, 2025
be33b90
Consolidate EH clause errors, check end offsets, move CodeSizeZero ch…
Copilot Nov 30, 2025
de33bbd
Fix potential integer overflow in EH clause bounds check
Copilot Nov 30, 2025
cda2550
Merge InvalidExceptionRegionTests into ExceptionRegionTests
Copilot Nov 30, 2025
b4811c8
Remove redundant comments and move -ERR flag to ILTests.targets
Copilot Nov 30, 2025
cb5ad59
Remove invalid IL tests that cannot be compiled by ilasm
Copilot Nov 30, 2025
25b6322
Add tests for invalid exception region offsets using decimal numbers
Copilot Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/coreclr/tools/Common/TypeSystem/IL/ILImporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,23 @@ private void FindEHTargets()
{
var r = _exceptionRegions[i];

CreateBasicBlock(r.ILRegion.TryOffset).TryStart = true;
if ((uint)r.ILRegion.TryOffset < (uint)_basicBlocks.Length)
CreateBasicBlock(r.ILRegion.TryOffset).TryStart = true;
else
ReportInvalidBranchTarget(r.ILRegion.TryOffset);

if (r.ILRegion.Kind == ILExceptionRegionKind.Filter)
CreateBasicBlock(r.ILRegion.FilterOffset).FilterStart = true;
CreateBasicBlock(r.ILRegion.HandlerOffset).HandlerStart = true;
{
if ((uint)r.ILRegion.FilterOffset < (uint)_basicBlocks.Length)
CreateBasicBlock(r.ILRegion.FilterOffset).FilterStart = true;
else
ReportInvalidBranchTarget(r.ILRegion.FilterOffset);
}

if ((uint)r.ILRegion.HandlerOffset < (uint)_basicBlocks.Length)
CreateBasicBlock(r.ILRegion.HandlerOffset).HandlerStart = true;
else
ReportInvalidBranchTarget(r.ILRegion.HandlerOffset);
}
}

Expand Down
Loading