[release/10.0] Do not ignore ClassLoader::ResolveTokenToTypeDefThrowing return values #121968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResolveTokenToTypeDefThrowing can return FALSE in some situations when the token cannot be resolved. The calling code has to deal with the situation gracefully since the [out] arguments are not initialized in that case. Fixes #121791
AaronRobinsonMSFT
approved these changes
Nov 25, 2025
Contributor
|
Tagging subscribers to this area: @mangod9 |
rbhanda
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #121864 to release/10.0
/cc @jkotas
Customer Impact
Customer observed crash in NUnit project after upgrading to .NET 10. The bug is triggered by a static field that:
The fix is the add missing error handling in a few places.
Regression
Regressions introduced by #114675 (runtime async feature) and #118413 (type loading perf work)
Testing
Targeted repro, distilled to a test
Risk
Low. The fix is just an extra error handling.