Skip to content

Conversation

@matouskozak
Copy link
Member

@matouskozak matouskozak commented Nov 24, 2025

Build Mono smoke tests on Azdo build images to work around an issue where helix machines have lower XCode than Azdo images, causing Mono linking errors: #120589 (comment)

Changes:

  • Correct Directory.Build.* imports for functional tests
  • Tweak src/libraries/sendtohelix-mobile.targets to handle cases where only runonly tests are prepared for sending to helix.
  • Rename mobile jobs running only smoke tests

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 24, 2025
@matouskozak matouskozak added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 24, 2025
@matouskozak matouskozak reopened this Nov 25, 2025
@matouskozak matouskozak changed the title [Testing] Try macOS-14 azdo images [Testing][iOS] Try macOS-15 azdo images Nov 26, 2025
@matouskozak matouskozak changed the title [Testing][iOS] Try macOS-15 azdo images [infra][iOS] Fully build smoke tests on azdo build images Dec 3, 2025
@matouskozak matouskozak added os-ios Apple iOS and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Dec 4, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@matouskozak
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@matouskozak
Copy link
Member Author

I've tried building full libraries suit on macOS azdo machine but it took over 4h and then got cancelled (https://dev.azure.com/dnceng-public/public/_build/results?buildId=1220044&view=logs&jobId=6ad81d5f-e956-5767-2437-61a9fc4dc8db&j=acac6bf3-3edd-5022-4e45-3362a02520b1&t=311ccc8e-0304-52d0-3115-8f8cb0052fd2), we will need the helix build step when helix queues get updated.

@matouskozak matouskozak marked this pull request as ready for review December 4, 2025 13:23
Copilot AI review requested due to automatic review settings December 4, 2025 13:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables building Mono smoke tests on Azure DevOps build images instead of Helix machines to work around XCode version incompatibilities. The changes include correcting import paths for functional tests, improving the robustness of mobile test handling, and renaming pipeline jobs for clarity.

Key Changes:

  • Corrected Directory.Build.* import paths for iOS/tvOS functional tests to reference the correct parent directory
  • Enhanced sendtohelix-mobile.targets with existence checks and path corrections for run-only test scenarios
  • Removed /p:BuildTestsOnHelix=true from iOS/tvOS device builds and renamed mobile smoke test jobs with _Smoke suffix for clarity

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/tests/FunctionalTests/tvOS/Device/AOT/Directory.Build.targets Corrected import path from libraries directory to FunctionalTests parent directory
src/tests/FunctionalTests/tvOS/Device/AOT/Directory.Build.props Corrected import path from libraries directory to FunctionalTests parent directory
src/tests/FunctionalTests/iOS/Device/Directory.Build.targets Corrected import path from libraries directory to FunctionalTests parent directory
src/tests/FunctionalTests/iOS/Device/Directory.Build.props Corrected import path from libraries directory to FunctionalTests parent directory
src/libraries/sendtohelix-mobile.targets Added existence checks, CustomCommands for runonly tests, and fixed Exclude path for consistency
eng/pipelines/runtime.yml Renamed mobile smoke test jobs with _Smoke suffix, removed BuildTestsOnHelix parameter, and re-enabled iOS/tvOS device test execution
eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml Renamed CoreCLR smoke test job with _Smoke suffix
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml Renamed CoreCLR smoke test job with _Smoke suffix
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml Renamed NativeAOT and CoreCLR smoke test jobs with _Smoke suffix

@kotlarmilos kotlarmilos self-requested a review December 4, 2025 14:09
Copy link
Member

@kotlarmilos kotlarmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@matouskozak matouskozak enabled auto-merge (squash) December 4, 2025 16:59
@matouskozak matouskozak merged commit f6d570f into dotnet:main Dec 4, 2025
173 of 175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants