-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[infra][iOS] Fully build smoke tests on azdo build images #121927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2c98be1 to
55e357d
Compare
21253ac to
021383f
Compare
85f913f to
010bc9b
Compare
70e1828 to
a2c1fd3
Compare
|
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger |
|
/azp run runtime-ioslike,runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
540d1bb to
b0d119b
Compare
|
I've tried building full libraries suit on macOS azdo machine but it took over 4h and then got cancelled (https://dev.azure.com/dnceng-public/public/_build/results?buildId=1220044&view=logs&jobId=6ad81d5f-e956-5767-2437-61a9fc4dc8db&j=acac6bf3-3edd-5022-4e45-3362a02520b1&t=311ccc8e-0304-52d0-3115-8f8cb0052fd2), we will need the helix build step when helix queues get updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables building Mono smoke tests on Azure DevOps build images instead of Helix machines to work around XCode version incompatibilities. The changes include correcting import paths for functional tests, improving the robustness of mobile test handling, and renaming pipeline jobs for clarity.
Key Changes:
- Corrected
Directory.Build.*import paths for iOS/tvOS functional tests to reference the correct parent directory - Enhanced
sendtohelix-mobile.targetswith existence checks and path corrections for run-only test scenarios - Removed
/p:BuildTestsOnHelix=truefrom iOS/tvOS device builds and renamed mobile smoke test jobs with_Smokesuffix for clarity
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/FunctionalTests/tvOS/Device/AOT/Directory.Build.targets | Corrected import path from libraries directory to FunctionalTests parent directory |
| src/tests/FunctionalTests/tvOS/Device/AOT/Directory.Build.props | Corrected import path from libraries directory to FunctionalTests parent directory |
| src/tests/FunctionalTests/iOS/Device/Directory.Build.targets | Corrected import path from libraries directory to FunctionalTests parent directory |
| src/tests/FunctionalTests/iOS/Device/Directory.Build.props | Corrected import path from libraries directory to FunctionalTests parent directory |
| src/libraries/sendtohelix-mobile.targets | Added existence checks, CustomCommands for runonly tests, and fixed Exclude path for consistency |
| eng/pipelines/runtime.yml | Renamed mobile smoke test jobs with _Smoke suffix, removed BuildTestsOnHelix parameter, and re-enabled iOS/tvOS device test execution |
| eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml | Renamed CoreCLR smoke test job with _Smoke suffix |
| eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml | Renamed CoreCLR smoke test job with _Smoke suffix |
| eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml | Renamed NativeAOT and CoreCLR smoke test jobs with _Smoke suffix |
kotlarmilos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Build Mono smoke tests on Azdo build images to work around an issue where helix machines have lower XCode than Azdo images, causing Mono linking errors: #120589 (comment)
Changes:
Directory.Build.*imports for functional testssrc/libraries/sendtohelix-mobile.targetsto handle cases where onlyrunonlytests are prepared for sending to helix.