Cleanup most usages of Windows file mapping #121896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
added
area-PAL-coreclr
and removed
needs-area-label
jkotas
reviewed
Nov 28, 2025
| #ifdef HOST_WINDOWS | ||
| #define MEMORY_MAPPED_STRESSLOG_BASE_ADDRESS (void*)0x400000000000 | ||
| #else | ||
| #define MEMORY_MAPPED_STRESSLOG_BASE_ADDRESS nullptr |
Member
There was a problem hiding this comment.
Is this removing support for memory mapped stresslog on non-Windows?
Member
Author
There was a problem hiding this comment.
Yes. NativeAOT copy of stresslog removes memory map support on all platforms. I haven't measured the impact.
jkotas
reviewed
Nov 28, 2025
This was referenced Dec 5, 2025
jkotas
reviewed
Dec 5, 2025
src/coreclr/minipal/dn-memmap.h
Outdated
Comment on lines
15
to
18
| #ifdef TARGET_WINDOWS | ||
| HANDLE m_hFileMapping; | ||
| #endif | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| #ifdef TARGET_WINDOWS | |
| HANDLE m_hFileMapping; | |
| #endif | |
This can be deleted from here (close the FileMapping handle at the end of the Open method instead)
jkotas
reviewed
Dec 5, 2025
|
|
||
| Fail: | ||
| if (hFile != INVALID_HANDLE_VALUE) | ||
| CloseHandle(hFile); |
Member
There was a problem hiding this comment.
This handle should be closed on the success path too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining cases are superpmi (included in #121367) and PEImage, which involves LoadLibrary and we would want more future-proof abstraction.
All the cases included in this PR are transitively used by ilasm/ildasm. For stgio, I'm doing simple ifdef's on OS api, since it's too complicated around different I/O models, and we would get rid of it with new metadata library.