-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add runtime-async smoke tests for NativeAOT #121895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
db33a0d to
0b92a72
Compare
|
Smoketest results on QEMU: linux-riscv64 aot: https://github.com/am11/CrossRepoCITesting/actions/runs/19601387216 |
Is runtime async tested anywhere in this PR? From what I can see this enables runtime-async in the C# compiler and then uses the custom attribute to turn it off everywhere (we would see Linux being broken in the CI runs if this was testing runtime async, because it's broken on Linux as of tip of main). Also to clarify what I meant with "slowly moving away from adding AOT-specific testing for things that are not AOT specific" (#121857 (comment)) so that we're on the same page - we are actively deleting native AOT tests that don't test any AOT specific behaviors. E.g. #120949 is deleting the ComWrappers test. The PInvoke.cs and Threading.cs tests will likely follow too, once we confirm we're not losing coverage. We are aligning testing strategy with JIT-based CoreCLR. Full VM also doesn't have smoke tests; the testing strategies should be the same. The nativeaot subtree should eventually only have AOT-specific testing. |
We are relying on smoke tests for community-platform where testing is blocked #121857 (comment). If it isn't causing major overheads, I suggest we keep them for now. |
|
I agree with @MichalStrehovsky. We should not be adding more redundant testing to native smoke tests.
It would be better to spend the energy on getting this unblocked. Are the F# tests the only ones that are causing problems (#115622) - does the rest work if you disable the F# tests? |
|
Ok, I will keep these tests in local branch for a while for quick validation once reloc issues are sorted out (we will need to remove
The proper way would be to hook into bootstrap ridgraph mechanism for tests. I will try to work on it next.
F# is one of (many) nuget feeds there, the failing tests are due to tests infra not using the bootstrapped runtime packs. Previously, we fixed that by adding |
No description provided.