Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Nov 22, 2025

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 22, 2025
@am11 am11 added arch-loongarch64 arch-riscv Related to the RISC-V architecture labels Nov 22, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@am11 am11 force-pushed the chore/smoketess-runtime-async branch from db33a0d to 0b92a72 Compare November 22, 2025 21:19
@MichalStrehovsky
Copy link
Member

Add runtime-async smoke tests for NativeAOT

Is runtime async tested anywhere in this PR? From what I can see this enables runtime-async in the C# compiler and then uses the custom attribute to turn it off everywhere (we would see Linux being broken in the CI runs if this was testing runtime async, because it's broken on Linux as of tip of main).

Also to clarify what I meant with "slowly moving away from adding AOT-specific testing for things that are not AOT specific" (#121857 (comment)) so that we're on the same page - we are actively deleting native AOT tests that don't test any AOT specific behaviors. E.g. #120949 is deleting the ComWrappers test. The PInvoke.cs and Threading.cs tests will likely follow too, once we confirm we're not losing coverage. We are aligning testing strategy with JIT-based CoreCLR. Full VM also doesn't have smoke tests; the testing strategies should be the same. The nativeaot subtree should eventually only have AOT-specific testing.

@am11
Copy link
Member Author

am11 commented Nov 24, 2025

The nativeaot subtree should eventually only have AOT-specific testing.

We are relying on smoke tests for community-platform where testing is blocked #121857 (comment). If it isn't causing major overheads, I suggest we keep them for now.

@jkotas
Copy link
Member

jkotas commented Nov 24, 2025

I agree with @MichalStrehovsky. We should not be adding more redundant testing to native smoke tests.

blocked #121857 (comment)

It would be better to spend the energy on getting this unblocked.

Are the F# tests the only ones that are causing problems (#115622) - does the rest work if you disable the F# tests?

@am11
Copy link
Member Author

am11 commented Nov 24, 2025

Ok, I will keep these tests in local branch for a while for quick validation once reloc issues are sorted out (we will need to remove [RuntimeAsyncMethodGeneration(false)] lines to actually make it fail).

It would be better to spend the energy on getting this unblocked.

The proper way would be to hook into bootstrap ridgraph mechanism for tests. I will try to work on it next.

Are the F# tests the only ones that are causing problems (#115622) - does the rest work if you disable the F# tests?

F# is one of (many) nuget feeds there, the failing tests are due to tests infra not using the bootstrapped runtime packs. Previously, we fixed that by adding -p:UseLocalAppHostPack=true: #99354 but we should try to do it properly by importing eng/targetingpacks.targets and wire it up with UseBootstrapLayout.

@am11 am11 closed this Nov 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-loongarch64 arch-riscv Related to the RISC-V architecture area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member runtime-async

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants