[browser][mono] ST build is always sidecar on a worker #121879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
This was referenced Nov 21, 2025
Copilot finished reviewing on behalf of
pavelsavara
November 24, 2025 10:25
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where single-threaded (ST) builds were not always properly marking workers as sidecars. The change ensures that in ST builds, any web worker becomes a sidecar, while in multi-threaded (MT) builds, only the first script loaded in a worker becomes the sidecar.
- Modified the sidecar detection logic to account for ST vs MT builds
- Added import for
WasmEnableThreadsconstant to enable build-time detection
maraf
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #114918 (comment)