Fix access violation when reporting fatal errors during startup #121602
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
With this fix, we should see the following error message on unpatched Windows 10 machines: |
Contributor
|
Tagging subscribers to this area: @mangod9 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an access violation that occurs when ThreadStore::HoldingThreadStore() is called during early startup from HandleFatalError, before the thread store has been initialized.
Key changes:
- Added a null check for
s_pThreadStoreinHoldingThreadStore()to prevent dereferencing a null pointer during early startup error handling
agocke
approved these changes
Nov 13, 2025
elinor-fung
approved these changes
Nov 13, 2025
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
4 tasks
Member
Author
|
/ba-g timeouts |
This was referenced Nov 14, 2025
Open
steveisok
pushed a commit
that referenced
this pull request
Nov 21, 2025
…g startup (#121605) Backport of #121602 to release/10.0 /cc @jkotas ## Customer Impact Allow customers to self-diagnose fail fasts encountered early during startup, such as running on unpatched Windows 10 machine that does not support CET correctly. This change fixes crash during printing of the fail fast error message early during startup. - [x] Customer reported - [ ] Found internally ## Regression - [ ] Yes - [x] No ## Testing Manual simulated test ## Risk Low Co-authored-by: Jan Kotas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121596