Skip to content

Runtime-async continuation object reading with Cordb #121432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcj1 merged 2 commits into from
Dec 1, 2025
Merged

Runtime-async continuation object reading with Cordb #121432

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1531ce
continuation object reading with cordb
rcj1 Nov 6, 2025
5cf0fdd
code review
rcj1 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/coreclr/debug/daccess/dacdbiimpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2315,6 +2315,10 @@ void DacDbiInterfaceImpl::GetClassTypeInfo(TypeHandle typeH
DebuggerIPCE_ExpandedTypeData * pTypeInfo,
AppDomain * pAppDomain)
{
if (typeHandle.AsMethodTable()->IsContinuation())
Comment thread
rcj1 marked this conversation as resolved.
Outdated
Comment thread
rcj1 marked this conversation as resolved.
Outdated
{
typeHandle = TypeHandle(g_pContinuationClassIfSubTypeCreated);
Comment thread
rcj1 marked this conversation as resolved.
Outdated
}
Module * pModule = typeHandle.GetModule();

if (typeHandle.HasInstantiation()) // the type handle represents a generic instantiation
Expand Down Expand Up @@ -2402,9 +2406,13 @@ void DacDbiInterfaceImpl::TypeHandleToBasicTypeInfo(TypeHandle
case ELEMENT_TYPE_CLASS:
case ELEMENT_TYPE_VALUETYPE:
{
Module * pModule = typeHandle.GetModule();
if (typeHandle.AsMethodTable()->IsContinuation())
{
typeHandle = TypeHandle(g_pContinuationClassIfSubTypeCreated);
Comment thread
rcj1 marked this conversation as resolved.
Outdated
}

if (typeHandle.HasInstantiation()) // only set if instantiated
Module * pModule = typeHandle.GetModule();
if (typeHandle.HasInstantiation()) // only set if instantiated
{
pTypeInfo->vmTypeHandle.SetDacTargetPtr(typeHandle.AsTAddr());
}
Expand Down
8 changes: 8 additions & 0 deletions src/coreclr/debug/ee/debugger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11657,6 +11657,10 @@ void Debugger::TypeHandleToBasicTypeInfo(AppDomain *pAppDomain, TypeHandle th, D
case ELEMENT_TYPE_CLASS:
case ELEMENT_TYPE_VALUETYPE:
{
if (th.AsMethodTable()->IsContinuation())
{
th = TypeHandle(g_pContinuationClassIfSubTypeCreated);
Comment thread
rcj1 marked this conversation as resolved.
Outdated
}
res->vmTypeHandle = th.HasInstantiation() ? WrapTypeHandle(th) : VMPTR_TypeHandle::NullPtr();
// only set if instantiated
res->metadataToken = th.GetCl();
Expand Down Expand Up @@ -11739,6 +11743,10 @@ void Debugger::TypeHandleToExpandedTypeInfo(AreValueTypesBoxed boxed,
case ELEMENT_TYPE_CLASS:
{
treatAllValuesAsBoxed:
if (th.AsMethodTable()->IsContinuation())
{
th = TypeHandle(g_pContinuationClassIfSubTypeCreated);
Comment thread
rcj1 marked this conversation as resolved.
Outdated
}
res->ClassTypeData.typeHandle = th.HasInstantiation() ? WrapTypeHandle(th) : VMPTR_TypeHandle::NullPtr(); // only set if instantiated
res->ClassTypeData.metadataToken = th.GetCl();
DebuggerModule * pModule = LookupOrCreateModule(th.GetModule());
Expand Down
Loading