arm64: Fix negs compare to minus int.MinValue #121380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonathandavies-arm
commented
Nov 5, 2025
jonathandavies-arm
commented
- Fixes JIT: Wrong result of comparison against 0 on arm64 #121294
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
|
@dotnet/arm64-contrib @jakobbotsch Please can I have a review? |
jakobbotsch
reviewed
Nov 5, 2025
This was referenced Nov 5, 2025
Open
This was referenced Nov 7, 2025
3 tasks
tannergooding
approved these changes
Nov 14, 2025
Member
tannergooding
left a comment
tannergooding
left a comment
There was a problem hiding this comment.
This resolves the issue and any potential regressions are tracked by #121445
This was referenced Nov 14, 2025
jakobbotsch
reviewed
Nov 17, 2025
jakobbotsch
reviewed
Nov 18, 2025
jakobbotsch
reviewed
Nov 18, 2025
Contributor
|
@jakobbotsch thanks for fixing this up. This looks good to me now? The failures are just CI issues |
3 tasks
Member
jakobbotsch
added a commit
that referenced
this pull request
Dec 5, 2025
arm32 does not set the right flags for these operations, so it cannot be enabled. I enabled this in #121380, and these tests did fail there too, but I mistakenly thought the failure was preexisting and the same as #121659. Also do a small refactoring while I'm here, to make use of `SupportsSettingFlagsAsCompareToZero` from `SupportsSettingZeroFlag`. Fix #122185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.