Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2ccb116
Initial plan
Copilot Nov 5, 2025
6ea1ef6
Use helix platform variable aliases for macOS ARM64 and x64 queues
Copilot Nov 5, 2025
65c5bd5
Import helix-platforms.yml in common variables for variable availability
Copilot Nov 5, 2025
363d319
Import helix-platforms.yml directly in helix-queues-setup files inste…
Copilot Nov 5, 2025
59982bd
Fix CI: Import helix-platforms.yml in xplat-setup.yml instead of heli…
Copilot Nov 5, 2025
217f94b
Remove duplicate helix-platforms.yml import from common/variables.yml
Copilot Nov 5, 2025
49d8d18
Move helix-platforms.yml import to helix-queues-setup files as variab…
Copilot Nov 5, 2025
d3e2d5c
Move variables to runtime pipeline
agocke Nov 6, 2025
8d6b31b
Move generic definitions to the bottom of the file
agocke Nov 6, 2025
688fc98
Use macro expansion
agocke Nov 6, 2025
2f9351c
Re-add variables import to libraries helix-platforms
agocke Nov 6, 2025
a6a5d3e
Typo
agocke Nov 6, 2025
b0c9ff0
Move back to global definition, but change use to runtime evaluation
agocke Nov 6, 2025
ebc5ee6
Re-add to runtime pipeline as global
agocke Nov 6, 2025
3a77451
Update macOS x64 to version 26 and use template substitution for vari…
Copilot Nov 6, 2025
f104a05
Use runtime expansion for helix variables and revert variables parame…
Copilot Nov 6, 2025
b8874e3
Update helix_macos_x64_latest_internal to OSX.26 for consistency
Copilot Nov 7, 2025
aaef983
Merge branch 'main' into copilot/update-helix-queue-names
agocke Nov 10, 2025
401b4c7
Merge branch 'main' into copilot/update-helix-queue-names
agocke Nov 12, 2025
51749e3
Merge branch 'main' into copilot/update-helix-queue-names
agocke Nov 13, 2025
c9c9f1c
Merge branch 'main' into copilot/update-helix-queue-names
agocke Nov 17, 2025
b4e9ac8
Update macOS x64 latest to OSX.15 (Sequoia 15)
Copilot Nov 17, 2025
e899216
Merge branch 'main' into copilot/update-helix-queue-names
agocke Nov 19, 2025
80ad629
Merge branch 'main' into copilot/update-helix-queue-names
agocke Nov 19, 2025
5855401
Temporarily skip MatchesCodesignOutput test due to macOS 26 behavior …
Copilot Nov 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/pipelines/common/variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@

variables:

# These values enable longer delays, configurable number of retries, and special understanding of TCP hang-up

Check warning on line 8 in eng/pipelines/common/variables.yml

View workflow job for this annotation

GitHub Actions / copilot

8:81 [line-length] line too long (109 > 80 characters)
# See https://github.com/NuGet/Home/issues/11027 for details
- name: NUGET_ENABLE_EXPERIMENTAL_HTTP_RETRY

Check warning on line 10 in eng/pipelines/common/variables.yml

View workflow job for this annotation

GitHub Actions / copilot

10:1 [indentation] wrong indentation: expected 2 but found 0
value: true
- name: NUGET_EXPERIMENTAL_MAX_NETWORK_TRY_COUNT
value: 6
Expand All @@ -19,7 +19,7 @@
value: ${{ eq(variables['Build.DefinitionName'], 'dotnet-runtime-codeql') }}

- name: isOfficialBuild
value: ${{ and(eq(variables['System.TeamProject'], 'internal'), eq(variables['Build.DefinitionName'], 'dotnet-runtime-official')) }}

Check warning on line 22 in eng/pipelines/common/variables.yml

View workflow job for this annotation

GitHub Actions / copilot

22:81 [line-length] line too long (134 > 80 characters)
- name: isRollingBuild
value: ${{ ne(variables['Build.Reason'], 'PullRequest') }}
- name: isExtraPlatformsBuild
Expand All @@ -27,11 +27,11 @@
- name: isNotExtraPlatformsBuild
value: ${{ ne(variables['Build.DefinitionName'], 'runtime-extra-platforms') }}
- name: isWasmOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-wasm-dbgtests', 'runtime-wasm-optional') }}

Check warning on line 30 in eng/pipelines/common/variables.yml

View workflow job for this annotation

GitHub Actions / copilot

30:81 [line-length] line too long (173 > 80 characters)
- name: isiOSLikeOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-ioslike') }}
- name: isiOSLikeSimulatorOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-ioslikesimulator') }}

Check warning on line 34 in eng/pipelines/common/variables.yml

View workflow job for this annotation

GitHub Actions / copilot

34:81 [line-length] line too long (81 > 80 characters)
- name: isAndroidOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-android') }}
- name: isAndroidEmulatorOnlyBuild
Expand All @@ -41,9 +41,9 @@
- name: isLinuxBionicOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-linuxbionic') }}
- name: isRunSmokeTestsOnly
value: ${{ notin(variables['Build.DefinitionName'], 'runtime-extra-platforms', 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-ioslike', 'runtime-ioslikesimulator', 'runtime-android', 'runtime-androidemulator', 'runtime-maccatalyst', 'runtime-linuxbionic') }}

Check warning on line 44 in eng/pipelines/common/variables.yml

View workflow job for this annotation

GitHub Actions / copilot

44:81 [line-length] line too long (292 > 80 characters)
- name: isNotSpecificPlatformOnlyBuild
value: ${{ notin(variables['Build.DefinitionName'], 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-ioslike', 'runtime-ioslikesimulator', 'runtime-android', 'runtime-androidemulator', 'runtime-maccatalyst', 'runtime-linuxbionic') }}

Check warning on line 46 in eng/pipelines/common/variables.yml

View workflow job for this annotation

GitHub Actions / copilot

46:81 [line-length] line too long (265 > 80 characters)

- name: debugOnPrReleaseOnRolling
${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
Expand All @@ -58,4 +58,6 @@
ne(variables['isExtraPlatformsBuild'], true),
eq(variables['isRollingBuild'], true))) ]

- template: /eng/common/${{ parameters.templatePath }}/variables/pool-providers.yml

Check warning on line 61 in eng/pipelines/common/variables.yml

View workflow job for this annotation

GitHub Actions / copilot

61:81 [line-length] line too long (83 > 80 characters)

- template: /eng/pipelines/helix-platforms.yml
1 change: 1 addition & 0 deletions eng/pipelines/common/xplat-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:

variables:
- template: /eng/common/${{ coalesce(parameters.jobParameters.templatePath, 'templates') }}/variables/pool-providers.yml
- template: /eng/pipelines/helix-platforms.yml
# Disable component governance in our CI builds. These builds are not shipping nor
# are they a service. Also the component governance jobs issue lots of inconsequential
# warnings and errors into our build timelines that make it hard to track down
Expand Down
11 changes: 4 additions & 7 deletions eng/pipelines/coreclr/templates/helix-queues-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,20 +104,17 @@ jobs:

# OSX arm64
- ${{ if eq(parameters.platform, 'osx_arm64') }}:
- ${{ if and(eq(variables['System.TeamProject'], 'public'), eq(parameters.jobParameters.isExtraPlatformsBuild, true)) }}:
- OSX.26.Arm64.Open
- ${{ if and(eq(variables['System.TeamProject'], 'public'), ne(parameters.jobParameters.isExtraPlatformsBuild, true), ne(parameters.jobParameters.helixQueueGroup, 'superpmi-diffs')) }}:
- OSX.13.Arm64.Open
- ${{ if and(eq(variables['System.TeamProject'], 'public'), ne(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.helixQueueGroup, 'superpmi-diffs')) }}:
# superpmi is not about testing platform differences, so go with highest capacity queue
- ${{ if and(eq(variables['System.TeamProject'], 'public'), ne(parameters.jobParameters.helixQueueGroup, 'superpmi-diffs')) }}:
- ${{ variables.helix_macos_arm64 }}
- ${{ if and(eq(variables['System.TeamProject'], 'public'), eq(parameters.jobParameters.helixQueueGroup, 'superpmi-diffs')) }}:
- OSX.14.Arm64.Open
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- OSX.14.Arm64

# OSX x64
- ${{ if eq(parameters.platform, 'osx_x64') }}:
- ${{ if eq(variables['System.TeamProject'], 'public') }}:
- OSX.13.Amd64.Open
- ${{ variables.helix_macos_x64 }}
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- OSX.13.Amd64

Expand Down
7 changes: 2 additions & 5 deletions eng/pipelines/installer/helix-queues-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,11 @@ jobs:

# OSX arm64
- ${{ if eq(parameters.platform, 'osx_arm64') }}:
- ${{ if eq(parameters.jobParameters.isExtraPlatformsBuild, true) }}:
- OSX.26.Arm64.Open
- ${{ if ne(parameters.jobParameters.isExtraPlatformsBuild, true) }}:
- osx.13.Arm64.Open
- ${{ variables.helix_macos_arm64 }}

# OSX x64
- ${{ if eq(parameters.platform, 'osx_x64') }}:
- OSX.13.Amd64.Open
- ${{ variables.helix_macos_x64 }}

# windows x64
- ${{ if eq(parameters.platform, 'windows_x64') }}:
Expand Down
7 changes: 2 additions & 5 deletions eng/pipelines/libraries/helix-queues-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,11 @@ jobs:

# OSX arm64
- ${{ if eq(parameters.platform, 'osx_arm64') }}:
- ${{ if eq(parameters.jobParameters.isExtraPlatformsBuild, true) }}:
- OSX.26.Arm64.Open
- ${{ if ne(parameters.jobParameters.isExtraPlatformsBuild, true) }}:
- osx.13.arm64.open
- ${{ variables.helix_macos_arm64 }}

# OSX x64
- ${{ if eq(parameters.platform, 'osx_x64') }}:
- OSX.13.Amd64.Open
- ${{ variables.helix_macos_x64 }}

# Android
- ${{ if in(parameters.platform, 'android_x86', 'android_x64', 'linux_bionic_x64') }}:
Expand Down
Loading