-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Delete IA64-specific comment and associated code #121226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the jump instruction emission and decoding functions across multiple architectures (amd64, i386, arm, arm64, riscv64, loongarch64, wasm) to eliminate intermediate wrapper functions and consolidate the codebase. The changes rename emitJump and decodeJump to emitBackToBackJump and decodeBackToBackJump directly, removing the historical wrapper layer that was originally designed for IA64 architecture considerations.
Key changes:
- Consolidated
emitJump/decodeJumpandemitBackToBackJump/decodeBackToBackJumpinto single implementations - Removed obsolete IA64-specific comments about back-to-back jump optimization requirements
- Removed unused
GetAnyThunkTargetstub implementations from ARM64, RISCV64, and LoongArch64 architectures
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/amd64/cgenamd64.cpp | Consolidated isJumpRel32, isJumpRel64, decodeJump32, decodeJump64 into unified isBackToBackJump and decodeBackToBackJump; renamed emitJump to emitBackToBackJump; removed obsolete comment |
| src/coreclr/vm/amd64/cgencpu.h | Updated function declarations to use consolidated emitBackToBackJump, isBackToBackJump, and decodeBackToBackJump; removed inline wrapper implementations |
| src/coreclr/vm/i386/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations and obsolete IA64 comment |
| src/coreclr/vm/arm/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations and obsolete IA64 comment |
| src/coreclr/vm/arm64/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations |
| src/coreclr/vm/arm64/stubs.cpp | Removed unused GetAnyThunkTarget stub implementation |
| src/coreclr/vm/riscv64/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations |
| src/coreclr/vm/riscv64/stubs.cpp | Removed unused GetAnyThunkTarget stub implementation |
| src/coreclr/vm/loongarch64/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations |
| src/coreclr/vm/loongarch64/stubs.cpp | Removed unused GetAnyThunkTarget stub implementation |
| src/coreclr/vm/wasm/cgencpu.h | Removed obsolete IA64-specific comment about back-to-back jump optimization |
| src/coreclr/vm/precode.h | Updated call sites to use isBackToBackJump and decodeBackToBackJump |
| src/coreclr/vm/dynamicmethod.cpp | Updated call site to use emitBackToBackJump |
| src/coreclr/vm/codeman.cpp | Updated call site to use emitBackToBackJump |
Comments suppressed due to low confidence (1)
src/coreclr/vm/amd64/cgenamd64.cpp:496
- The comment references 'emitJump' but this function has been renamed to 'emitBackToBackJump'. Update the comment to:
// emitBackToBackJump may throw
THROWS; // emitBackToBackJump may throw (see emitJump)
|
/ba-g infrastructure timeouts |
No description provided.