Fix some System.Formats.Asn1 documentation mistakes #121179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects documentation errors in the System.Formats.Asn1 library. The changes fix incorrect universal tag numbers and parameter name references in XML documentation comments.
- Corrected universal tag numbers from 24 to 23 for UtcTime and from 1 to 3 for BitString
- Fixed incorrect parameter name references in Enumerated documentation from
enumTypetoexpectedTag - Fixed grammar error changing "a Enumerated" to "an Enumerated"
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AsnDecoder.UtcTime.cs | Corrected default tag documentation from Universal 24 to Universal 23 |
| AsnDecoder.Enumerated.cs | Fixed parameter name references from enumType to expectedTag and corrected grammar ("a" to "an") |
| AsnDecoder.BitString.cs | Corrected default tag documentation from Universal 1 to Universal 3 across three methods |
stephentoub
approved these changes
Oct 29, 2025
|
/ba-g Android and Windows NAOT lanes are timing out in this and in other PRs, these are documentation-only changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a small grammar mistake an a few references to the wrong Universal tag number.