Fix portable startup on OpenSSL 1.0 and 1.1.0 #120989
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a null pointer dereference in the portable build of the cryptography native library when running on OpenSSL 1.0. The issue occurred during SHA-3 algorithm light-up when the code attempted to call a function pointer without first verifying its existence.
Key Changes:
- Added an
API_EXISTScheck before calling the function pointer in the EVP_MD macro to prevent null dereference on older OpenSSL versions.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Open
3 tasks
vcsjones
changed the title
Member
|
Based on data gathering and discussion, we don't think 1.0.x or 1.1.0 are relevant to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SHA-3 light-up for portable builds against OpenSSL was missing an API_EXISTS check. This would result in a null-deref since it assumed the function pointer is non-NULL.
This only affects OpenSSL 1.0 and 1.1.0. 1.1.1 and 3 are not impacted.