JIT: Consider implicit byrefs to structs with byrefs as dead on suspension #120973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsion Structs with byrefs in them are considered dead on suspension. The spec requires these to be zeroed on resumption, so there is no need to capture them. The check, however, did not account for implicit byrefs to such structs. Fix this case.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the async liveness analysis where implicit byrefs to structs containing byrefs were incorrectly considered live at suspension points. According to the spec, structs with byrefs are zeroed on resumption, so they don't need to be captured.
Key Changes:
- Split the liveness check logic to properly handle implicit byrefs to structs with byrefs
- Ensure both explicit structs and implicit byref structs containing byrefs are treated as dead on suspension
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
PTAL @dotnet/jit-contrib |
EgorBo
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structs with byrefs in them are considered dead on suspension. The spec requires these to be zeroed on resumption, so there is no need to capture them.
The check, however, did not account for implicit byrefs to such structs. Fix this case.
Fix #119615