[DAC] properly 'dacize' async variant method sigs #120946
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds proper DAC (Data Access Component) support for async variant method signatures by ensuring the signature data is correctly marshaled when accessed from out-of-process debugging scenarios.
Key Changes:
- Adds DAC-specific handling in
MethodDesc::GetSig()for async variant methods to properly instantiate signature data in the debugger's address space
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of existing
StoredSigMethodDesc::GetStoredMethodSig