-
Couldn't load subscription status.
- Fork 5.2k
Add index to OrderedDictionary debugger display #120885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bb6f5f2
Initial plan
Copilot 2626dfa
Add index to OrderedDictionary debugger display
Copilot 284d2e9
Change OrderedDictionary debug view to list-style format
Copilot 9a0bf3c
Use string keys in OrderedDictionary test to distinguish from indices
Copilot 55a3368
Fix build error: Use conditional DebuggerTypeProxy for OrderedDictionary
Copilot 1a46e03
Add test to validate OrderedDictionary debugger display format
Copilot 6b09d2e
Remove conditional DebuggerTypeProxy by polyfilling OrderedDictionary…
Copilot e63a19b
Simplify OrderedDictionaryDebugView to use CopyTo
Copilot d7bade6
Fix build errors for .NET Framework by conditionally compiling Ordere…
Copilot 18654b3
Merge branch 'main' into copilot/add-index-to-ordered-dictionary
eiriktsarpalis baf8591
Merge branch 'main' into copilot/add-index-to-ordered-dictionary
stephentoub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
...libraries/System.Collections/src/System/Collections/Generic/OrderedDictionaryDebugView.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Diagnostics; | ||
|
|
||
| namespace System.Collections.Generic | ||
| { | ||
| internal sealed class OrderedDictionaryDebugView<TKey, TValue> where TKey : notnull | ||
| { | ||
| private readonly OrderedDictionary<TKey, TValue> _dictionary; | ||
|
|
||
| public OrderedDictionaryDebugView(OrderedDictionary<TKey, TValue> dictionary) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(dictionary); | ||
| _dictionary = dictionary; | ||
| } | ||
|
|
||
| [DebuggerBrowsable(DebuggerBrowsableState.RootHidden)] | ||
| public DebugViewOrderedDictionaryItem<TKey, TValue>[] Items | ||
| { | ||
| get | ||
| { | ||
| var items = new DebugViewOrderedDictionaryItem<TKey, TValue>[_dictionary.Count]; | ||
| int index = 0; | ||
| foreach (KeyValuePair<TKey, TValue> kvp in _dictionary) | ||
| { | ||
| items[index] = new DebugViewOrderedDictionaryItem<TKey, TValue>(index, kvp.Key, kvp.Value); | ||
| index++; | ||
| } | ||
| return items; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Defines an index/key/value triple for displaying an item of an ordered dictionary by a debugger. | ||
| /// </summary> | ||
| [DebuggerDisplay("{Value}", Name = "[{Index}/{Key}]")] | ||
| internal readonly struct DebugViewOrderedDictionaryItem<TKey, TValue> | ||
| { | ||
| public DebugViewOrderedDictionaryItem(int index, TKey key, TValue value) | ||
| { | ||
| Index = index; | ||
| Key = key; | ||
| Value = value; | ||
| } | ||
|
|
||
| [DebuggerBrowsable(DebuggerBrowsableState.Never)] | ||
| public int Index { get; } | ||
|
|
||
| [DebuggerBrowsable(DebuggerBrowsableState.Collapsed)] | ||
| public TKey Key { get; } | ||
|
|
||
| [DebuggerBrowsable(DebuggerBrowsableState.Collapsed)] | ||
| public TValue Value { get; } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.