Skip to content

Fix ArgumentException parameter name in ArrayBufferWriter #120880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
+3 −3
Merged

Fix ArgumentException parameter name in ArrayBufferWriter #120880

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58ee2c2
Initial plan
Copilot Oct 19, 2025
3d89e86
Fix ArgumentException in ArrayBufferWriter and add test
Copilot Oct 19, 2025
3733860
Use AssertExtensions.Throws for testing param name
Copilot Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/src/System/Buffers/ArrayBufferWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public Span<T> GetSpan(int sizeHint = 0)
private void CheckAndResizeBuffer(int sizeHint)
{
if (sizeHint < 0)
throw new ArgumentException(nameof(sizeHint));
throw new ArgumentException(null, nameof(sizeHint));

if (sizeHint == 0)
{
Expand Down
6 changes: 4 additions & 2 deletions src/libraries/System.Memory/tests/ArrayBufferWriter/ArrayBufferWriterTests.T.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,10 @@ public void InvalidGetMemoryAndSpan()
{
var output = new ArrayBufferWriter<T>();
WriteData(output, 2);
Assert.Throws<ArgumentException>(() => output.GetSpan(-1));
Assert.Throws<ArgumentException>(() => output.GetMemory(-1));
ArgumentException ex1 = Assert.Throws<ArgumentException>(() => output.GetSpan(-1));
Assert.Equal("sizeHint", ex1.ParamName);
ArgumentException ex2 = Assert.Throws<ArgumentException>(() => output.GetMemory(-1));
Assert.Equal("sizeHint", ex2.ParamName);
}

[Fact]
Expand Down
Loading