[release/10.0] Don't assume all S_IFREG files are seekable #120839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io |
adamsitnik
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
LGTM, but should we combine it with #120751 (once it gets merged)?
I leave that up to you, my main concern was cleaning up CI on release branches. If you think we should port the product fix as well, feel free to close this PR and then raise a combined PR with the fix once it is ready. Same for release/9.0 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120736 to release/10.0
/cc @rzikm
Customer Impact
None, the change is in Debug build only and doesn't affect shipped product.
Regression
No, test failures started after adding/updating AzureLinux3 OS in CI matrix.
Testing
CI passes.
Risk
Low, can be considered test-only change as the changes don't propagate to shipped product.