Support EVP_MAC for HMAC #120769
Closed
Support EVP_MAC for HMAC #120769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates HMAC implementation to use OpenSSL 3.0's EVP_MAC APIs instead of the deprecated HMAC APIs when running on OpenSSL 3+, while maintaining backward compatibility with older OpenSSL versions.
Key Changes
- Introduced
DN_MAC_CTXwrapper structure to support both legacy HMAC_CTX and new EVP_MAC_CTX implementations - Added runtime detection and initialization of EVP_MAC support
- Implemented workaround for OpenSSL 3.0.0-3.0.2 bug where EVP_MAC_init cannot reset with existing key
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pal_hmac.h |
Updated function signatures to use DN_MAC_CTX instead of HMAC_CTX and added the new context structure definition |
pal_hmac.c |
Implemented dual-path logic for EVP_MAC (OpenSSL 3.0+) and legacy HMAC APIs with version-specific workarounds |
osslcompat_30.h |
Added OSSL_MAC_PARAM_DIGEST constant and EVP_MD_get0_name function declaration for OpenSSL 3.0 compatibility |
opensslshim.h |
Registered new OpenSSL functions (CRYPTO_clear_free, CRYPTO_zalloc, EVP_MD_get0_name) and added version constant for OpenSSL 3.0.2 |
IncrementalHashTests.cs |
Added test case to verify HMAC cloning with empty keys works correctly |
src/libraries/System.Security.Cryptography/tests/IncrementalHashTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are on OpenSSL 3, we should use the EVP_MAC APIs instead of the now deprecated HMAC APIs.
Replaces #118856
Closes #118807
Contributes to #46526