[browser][mono][perf] partial revert 119307 119800 #120742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- revert wasm-opt to previous --enable-simd --enable-exception-handling --enable-bulk-memory
pavelsavara
added
arch-wasm
pavelsavara
changed the title
This was referenced Oct 16, 2025
pavelsavara
requested review from
akoeplinger,
ilonatommy and
maraf
as code owners
There was a problem hiding this comment.
Pull Request Overview
Partial revert of two prior changes: restoring the default of WasmNativeDebugSymbols to true and reverting the wasm-opt invocation to a reduced flag set (SIMD, exception handling, bulk memory only). Corresponding test expectations are updated to align with the reverted defaults, and a rebuild behavior test is modified to narrow what triggers relinking.
- Revert default WasmNativeDebugSymbols to true.
- Simplify wasm-opt flags back to minimal feature enables.
- Adjust tests to expect debug symbols always true and modify rebuild trigger logic.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/mono/wasm/build/WasmApp.Common.targets | Reverts defaults for debug symbols and simplifies wasm-opt flags. |
| src/mono/wasm/Wasm.Build.Tests/WasmNativeDefaultsTests.cs | Updates test expectations to always expect debug symbols enabled. |
| src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/FlagsChangeRebuildTest.cs | Alters rebuild test logic to ignore extraCFlags for determining relink and removes object file change tracking. |
src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/FlagsChangeRebuildTest.cs
Show resolved
Hide resolved
src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/FlagsChangeRebuildTest.cs
Show resolved
Hide resolved
radekdoulik
approved these changes
Oct 16, 2025
This was referenced Oct 22, 2025
[Perf] Linux/x64: 56 Regressions on 10/17/2025 6:02:57 AM +00:00
dotnet/perf-autofiling-issues#64281
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WasmNativeDebugSymbolsdefault to previoustruewasm-optto previous--enable-simd --enable-exception-handling --enable-bulk-memoryContributes to dotnet/perf-autofiling-issues#62390