Add some IL validity checks to interpreter #120682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds validity checks that calls BADCODE around some EH stuff and varargs calls and also replaces assert(0) in the primitive type conversion operations with BADCODE calls for the cases when invalid type conversions are requested.
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances IL validity checks in the interpreter by adding error handling for unsupported operations and invalid IL code patterns. The changes replace assert(0) calls with proper BADCODE error reporting and add validation for exception handling constructs and method calls.
Key changes:
- Adds validation for proper termination of emitted instruction sequences
- Introduces checks for unsupported varargs method calls
- Replaces assertion failures with descriptive BADCODE error messages for invalid type conversions
davidwrighton
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds validity checks that calls BADCODE around some EH stuff and varargs calls and also replaces assert(0) in the primitive type conversion operations with BADCODE calls for the cases when invalid type conversions are requested.