Fix TestReadyToRun to use the in-build crossgen #120678
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes crossgen2-related build failures by standardizing the use of Crossgen2InBuildDir instead of Crossgen2Dir for locating the crossgen2 tool. The change ensures that tests and builds consistently use the in-build crossgen2 location rather than a published directory that may not exist during certain build scenarios.
Key changes:
- Removes redundant
Crossgen2Dirproperty definitions - Updates targeting pack resolution to use
Crossgen2InBuildDir - Standardizes crossgen2 location references across build files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/Common/Directory.Build.targets | Removes empty Crossgen2Dir property definition that was overriding the conditional one |
| eng/targetingpacks.targets | Updates crossgen2 pack resolution to use Crossgen2InBuildDir instead of Crossgen2Dir |
| eng/liveBuilds.targets | Removes Crossgen2Dir property definition, keeping only Crossgen2InBuildDir |
github-actions
bot
added
the
needs-area-label
jkoritzinsky
added
area-crossgen2-coreclr
test-bug
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failures in runtime-coreclr crossgen2 pipeline and fixes
TestReadyToRun=truebuilds.