Skip to content

Enhance error handling in bundle extractor with ferror() and errno diagnostics #120676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+82 −1
Closed

Enhance error handling in bundle extractor with ferror() and errno diagnostics #120676

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4794543
Initial plan
Copilot Oct 13, 2025
b5d79b4
Add enhanced error handling to extractor.cpp with errno checks
Copilot Oct 13, 2025
4f7cc56
Add platform guards for EDQUOT errno constant
Copilot Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 82 additions & 1 deletion src/native/corehost/bundle/extractor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
#include "pal.h"
#include "utils.h"
#include <cinttypes>
#include <cerrno>
#include <cstring>

#ifdef __sun
#include <alloca.h>
Expand Down Expand Up @@ -160,6 +162,33 @@ void extractor_t::extract(const file_entry_t &entry, reader_t &reader)
{
CompressionNative_InflateEnd(&zStream);
trace::error(_X("I/O failure when writing decompressed file."));
if (ferror(file))
{
int err = errno;
const char* errMsg = strerror(err);
if (err == ENOSPC)
{
trace::error(_X("No space left on device (ENOSPC). Error: %s"), errMsg);
}
#ifdef EDQUOT
else if (err == EDQUOT)
{
trace::error(_X("Disk quota exceeded (EDQUOT). Error: %s"), errMsg);
}
#endif
else if (err == EIO)
{
trace::error(_X("I/O error (EIO). Error: %s"), errMsg);
}
else if (err == EFBIG)
{
trace::error(_X("File too large (EFBIG). Error: %s"), errMsg);
}
else
{
trace::error(_X("Write error. errno=%d, Error: %s"), err, errMsg);
}
}
throw StatusCode::BundleExtractionIOError;
}

Expand All @@ -181,10 +210,62 @@ void extractor_t::extract(const file_entry_t &entry, reader_t &reader)
{
trace::error(_X("Failure extracting contents of the application bundle. Expected size:%" PRId64 " Actual size:%zu"), size, extracted_size);
trace::error(_X("I/O failure when writing extracted files."));
if (ferror(file))
{
int err = errno;
const char* errMsg = strerror(err);
if (err == ENOSPC)
{
trace::error(_X("No space left on device (ENOSPC). Error: %s"), errMsg);
}
#ifdef EDQUOT
else if (err == EDQUOT)
{
trace::error(_X("Disk quota exceeded (EDQUOT). Error: %s"), errMsg);
}
#endif
else if (err == EIO)
{
trace::error(_X("I/O error (EIO). Error: %s"), errMsg);
}
else if (err == EFBIG)
{
trace::error(_X("File too large (EFBIG). Error: %s"), errMsg);
}
else
{
trace::error(_X("Write error. errno=%d, Error: %s"), err, errMsg);
}
}
fclose(file);
throw StatusCode::BundleExtractionIOError;
}

fclose(file);
if (fclose(file) != 0)
{
int err = errno;
const char* errMsg = strerror(err);
trace::error(_X("Failure closing extracted file."));
if (err == ENOSPC)
{
trace::error(_X("No space left on device (ENOSPC). Error: %s"), errMsg);
}
#ifdef EDQUOT
else if (err == EDQUOT)
{
trace::error(_X("Disk quota exceeded (EDQUOT). Error: %s"), errMsg);
}
#endif
else if (err == EIO)
{
trace::error(_X("I/O error (EIO). Error: %s"), errMsg);
}
else
{
trace::error(_X("Close error. errno=%d, Error: %s"), err, errMsg);
}
throw StatusCode::BundleExtractionIOError;
}
}

void extractor_t::begin()
Expand Down
Loading