Skip to content

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Oct 13, 2025

Description

Sets the environment variable used by xUnit to detect if a test is running in a CI environment. This enables the SkipOnCI attribute to work correctly on Apple mobile devices.

Contributes to dotnet/xharness#1473

@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 17:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the SkipOnCI attribute support on Apple mobile devices by ensuring the appropriate environment variable is passed to test apps. The change allows xUnit to properly detect when tests are running in a CI environment on iOS-like platforms.

Key changes:

  • Adds environment variable propagation to the xharness command for iOS-like test targets

@kotlarmilos kotlarmilos self-assigned this Oct 13, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 13, 2025
@kotlarmilos kotlarmilos removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 13, 2025
@kotlarmilos kotlarmilos added this to the 11.0.0 milestone Oct 13, 2025
@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@kotlarmilos kotlarmilos merged commit e66906a into dotnet:main Oct 14, 2025
160 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants