Fix build breaks with clang 21

[jkotas]

Contributes to #119706

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

[vcsjones]

The crypto changes look good.

Do we know when it is likely we are going to get a CI pipeline with clang 21? This seems likely to introduce again unless CI blocks it.

[jkotas]

Do we know when it is likely we are going to get a CI pipeline with clang 21?

Opened #120645 .

[tmds]

@jkotas thanks for addressing this! Can these changes be backported to .NET 10, and perhaps also earlier .NET versions?

[jkotas]

We do not backport fixes for C/C++ compiler warnings. We disable C/C++ warnings in release branches instead. I see that we forgot to do that for .NET 10. #120693 is fixing this.

[tmds]

@jkotas The changes for enum CorDebugUserState -1 value may have to be backported. I set PRERELEASE 0 and they still show up as an error (while the other ones become regular warnings).

[jkotas]

The changes for enum CorDebugUserState -1 value may have to be backported.

We can propose backport of all fixes required to make clang 21 work in your setup once we understand the full set. cc @AaronRobinsonMSFT .