Skip to content

Conversation

@kotlarmilos
Copy link
Member

Description

This PR disables the MemoryStream_CapacityBoundaryChecks test with [Fact(Skip = "...")]. Previously, SkipOnCI still allowed test to run on Apple mobile platforms which caused failures.

@kotlarmilos kotlarmilos requested review from alinpahontu2912 and Copilot and removed request for Copilot October 8, 2025 07:47
@kotlarmilos kotlarmilos self-assigned this Oct 8, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2025
@kotlarmilos kotlarmilos added os-ios Apple iOS area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 8, 2025
@kotlarmilos kotlarmilos added this to the 11.0.0 milestone Oct 8, 2025
@kotlarmilos
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@alinpahontu2912 alinpahontu2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I'd just change the comment from skipping on CI to always skipping since it won't run locally now either

@vitek-karas
Copy link
Member

I think the correct fix would be to do something about dotnet/xharness#1473. I looked into that some more and we probably don't want to change xharness itself, but instead modify how it's used from Arcade/Helix to pass the env. variables which denote CI runs to the tests.
There are now two tests in runtime which use the SkipOnCI attribute (for the same reason of allocating too much).

@kotlarmilos
Copy link
Member Author

Sorry I missed that. Yes, that sounds reasonable. Let’s move the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants