Fix DateTime fraction specifier parsing #120518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in DateTime fraction specifier parsing where the ".F" format pattern was not being handled correctly when the decimal point was missing from the input string. The fix removes incorrect nested braces that were preventing proper execution of the optional fraction handling logic.
- Corrects brace placement in DateTimeParse.cs to allow proper execution of optional fraction logic
- Adds comprehensive test coverage for .F, .FF, and .FFF format specifiers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeParse.cs | Fixes incorrect brace placement that was preventing optional fraction specifier logic from executing |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs | Adds test cases to verify .F format specifier parsing works correctly |
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
tarekgh
added
area-System.DateTime
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-datetime |
stephentoub
approved these changes
Oct 8, 2025
krwq
reviewed
Oct 8, 2025
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs
Show resolved
Hide resolved
krwq
approved these changes
Oct 8, 2025
…com/tarekgh/runtime into FixDateTimeFractionSpecifierParsing
jeffhandley
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120468