[release/10.0] Use switch statement to map socket errors #120447
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x.cs Co-authored-by: Copilot <[email protected]>
…x.cs Co-authored-by: Copilot <[email protected]>
…x.cs Co-authored-by: Stephen Toub <[email protected]>
MihaZupan
approved these changes
Oct 6, 2025
|
Tagging subscribers to this area: @dotnet/ncl |
JulieLeeMSFT
added
the
NO-MERGE
|
What's the plan with this PR @jkotas, @JulieLeeMSFT ? Should we turn it into Draft, if it is not ready / Close it for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120364 to release/10.0
/cc @am11 @jkotas
Customer Impact
NET 10.0 regressed startup time for trivial workloads as was reported by the AWS team in #120288. We suspect it's some new generic instantiations we introduced in .NET 10.0 around number parsing, since that is not easy to fix/backport, we just applied a few general improvements to regain the losses. This change reduces footprint of socket error map - eliminates extra Dictionary instantiations (about 20 JITed methods).
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Default test pass
Risk
Low