Skip to content

Remove unsafe bool casts #120400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

Remove unsafe bool casts #120400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Numerics/BFloat16.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ public static explicit operator BFloat16(double value)
// Extract sign bit
ulong sign = (bitValue & double.SignMask) >> 48;
// Detecting NaN (~0u if a is not NaN)
ulong realMask = (ulong)(Unsafe.BitCast<bool, sbyte>(double.IsNaN(value)) - 1);
ulong realMask = double.IsNaN(value) ? 0uL : ~0uL;
// Clear sign bit
value = double.Abs(value);
// Rectify values that are Infinity in BFloat16. (float.Min now emits vminps instruction if one of two arguments is a constant)
Expand Down
Loading