-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime-assets #120395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime-assets #120395
Conversation
…ld 20251003.1 On relative base path root Microsoft.DotNet.CilStrip.Sources , Microsoft.NET.HostModel.TestData , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 11.0.0-beta.25467.3 -> To Version 11.0.0-beta.25503.1
On relative base path root Microsoft.NETCore.Runtime.ICU.Transport From Version 11.0.0-alpha.1.25466.1 -> To Version 11.0.0-alpha.1.25504.2
…ild 20251002.5 On relative base path root Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 11.0.0-alpha.0.25479.1 -> To Version 11.0.0-alpha.0.25502.5
There are a couple of failures like:
@ViktorHofer Is this an issue with the dotnet/runtime-assets changes? |
Not runtime-assets. This is coming from dotnet/hotreload-utils. |
This means that hotreload-utils moved its SDK ahead of runtime which causes an issue when invoking apps due to the runtime version encoded in an app's runtimeconfig.json. |
@Youssef1313 why did you have to bump the sdk in dotnet/hotreload-utils#620 ? |
I bumped it to be able to use global.json's test runner. This wasn't available in RC1 |
…ld 20251007.1 On relative base path root Microsoft.DotNet.CilStrip.Sources , Microsoft.NET.HostModel.TestData , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 11.0.0-beta.25467.3 -> To Version 11.0.0-beta.25507.1
@akoeplinger @Youssef1313 Are there plans to fix these errors in dotnet/hotreload-utils before this PR is merged? Otherwise I can create a known issue for build analysis and merge this PR as-is. |
This will fix itself when RC2 is released and runtime updates to it. Meaning we probably want to park this PR for a week. Or, alternatively revert the SDK upgrade in hotreload-utils. This happen a few times in the past so it would be good to explicitly call this out somewhere in hotreload-utils. |
This pull request updates the following dependencies
From https://github.com/dotnet/runtime-assets
From https://github.com/dotnet/icu
From https://github.com/dotnet/hotreload-utils