[release/8.0-staging] Detect if RSA-384 is supported on the platform #120383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the previous hardcoded Windows version checking for RSA-384 support with a dynamic runtime detection system. The change was prompted by failing tests after a Windows Update caused RSA with 384-bit modulus to fail on previously supported Windows versions.
- Consolidated RSA-384 support detection into a centralized
PlatformSupport.IsRSA384Supportedproperty - Removed duplicated version-checking code from multiple RSA provider classes
- Added runtime capability testing by attempting to import known RSA-384 parameters
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
DefaultRSAProvider.cs |
Simplified Supports384PrivateKey to use centralized platform support detection |
RSACryptoServiceProviderProvider.cs |
Updated to use PlatformSupport.IsRSA384Supported instead of hardcoded true |
RSACngProvider.cs |
Removed duplicate Windows version checking logic, now uses centralized detection |
PlatformSupport.cs |
Added new IsRSA384Supported property with runtime detection logic and RSA-384 test parameters |
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
bartonjs
approved these changes
Oct 3, 2025
|
Test-only change, tell mode. |
jeffhandley
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120366 to release/8.0-staging
/cc @bartonjs
Customer Impact
This is test-only reaction to a change in Windows. Tests started failing in Windows because a Windows Update caused RSA with a 384-bit modulus to fail.
Regression
Testing
This is test only change. Verified failing tests started passing again.
Risk
None. Test-only change.