Protect throwable around interpreted funclet call #120377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InterpreterCodeManager::CallFunclet was not protecting the exceptionClauseArgs.throwable across the call to the interpreter. That lead to assert in some cases. This change fixes it.
There was a problem hiding this comment.
Pull Request Overview
This change fixes a garbage collection protection issue in the CoreCLR interpreter by adding proper GCPROTECT guards around the throwable object during funclet execution. The interpreter was not protecting the exceptionClauseArgs.throwable object across calls to InterpExecMethod, which could lead to assertion failures.
davidwrighton
approved these changes
Oct 3, 2025
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InterpreterCodeManager::CallFunclet was not protecting the exceptionClauseArgs.throwable across the call to the interpreter. That lead to assert in some cases.
This change fixes it.