Skip to content

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Oct 3, 2025

  • unify -fwasm-exceptions and -msimd128
  • fix gcinfo and create wasm static lib

@pavelsavara pavelsavara added this to the 11.0.0 milestone Oct 3, 2025
@pavelsavara pavelsavara self-assigned this Oct 3, 2025
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Oct 3, 2025
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara marked this pull request as ready for review October 3, 2025 15:34
@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 15:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR unifies the compiler and linker flags for WebAssembly builds by consistently adding both -fwasm-exceptions and -msimd128 flags across all CoreCLR WebAssembly build configurations.

  • Adds -msimd128 flag alongside existing -fwasm-exceptions flag for WASM builds
  • Updates multiple CMakeLists.txt files to ensure consistent SIMD support across CoreCLR components
  • Removes an obsolete TODO comment about JavaScript source maps

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/native/corehost/browserhost/sample/CMakeLists.txt Removes obsolete TODO comment about JS source maps
src/coreclr/pal/CMakeLists.txt Adds -msimd128 to both compile and link options for browser targets
src/coreclr/hosts/corewasmrun/CMakeLists.txt Adds -msimd128 to compile and link options for corewasmrun
src/coreclr/hosts/corerun/CMakeLists.txt Adds -msimd128 to compile and link options for browser builds
src/coreclr/CMakeLists.txt Adds -msimd128 to global compile and link options for WASM architecture

@pavelsavara pavelsavara changed the title [wasm][coreCLR] unify -fwasm-exceptions and -msimd128 [wasm][coreCLR] unify -fwasm-exceptions and -msimd128, gcinfo Oct 3, 2025
@pavelsavara
Copy link
Member Author

/ba-g known issues

#103347 and #119023

@pavelsavara pavelsavara merged commit a869b45 into dotnet:main Oct 4, 2025
124 of 127 checks passed
@pavelsavara pavelsavara deleted the browser_simd_exceptions branch October 4, 2025 07:43
@AaronRobinsonMSFT
Copy link
Member

Why are the compile and link options needed?

@pavelsavara
Copy link
Member Author

Why are the compile and link options needed?

it enables post-MVP features of the wasm spec, that were not a default for LLVM/emcc 2 years ago, when we last time updated the toolchain.
We plan to update the toolchain again soon, and I think we would get those flags by default.
#119409
#120222

There are more flags that i'm exploring here for Mono, but I didn't win yet #120423

does that answer the question ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-Infrastructure-coreclr os-browser Browser variant of arch-wasm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants