Fix time retrieval for Apple mobile in LogAssert #120358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotlarmilos
requested review from
Copilot and
huoyaoyuan
and removed request for
Copilot
github-actions
bot
added
the
needs-area-label
kotlarmilos
added
area-PAL-coreclr
os-ios
|
LGTM. Since the file is for debug only, it should prefer simplest approach without worrying about precision. It's also OK to be Windows/UNIX bipartite if that simplifies. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Oct 3, 2025
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
|
/azp run runtime-extra-platforms |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build issue on Apple mobile platforms (iOS, tvOS, macCatalyst) by replacing the use of timespec_get with gettimeofday for time retrieval in LogAssert functionality. The timespec_get function is only available on iOS 13+ while the minimum SDK target is iOS 12.2.
Key changes:
- Added conditional compilation for Apple mobile platforms to use
gettimeofdayinstead oftimespec_get - Included necessary header
<sys/time.h>for Apple mobile platforms - Converted
timevaltotimespecformat to maintain compatibility with existing code
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g extra-platforms evaluate paths was canceled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
timespec_getfunction introduced in #119543 is available only on iOS 13 and later, while the minimum SDK target is iOS 12.2. This change fixes CoreCLR Apple mobile build.Changes
Use
gettimeofdayto initializetimespecstruct.