[release/10.0] [mono][hotreload] Make the runtime ignore an update if it is an empty one. #120334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
github-actions
bot
requested review from
steveisok and
vitek-karas
as code owners
steveisok
changed the title
|
@lewing please review the changes. |
lewing
approved these changes
Oct 3, 2025
JulieLeeMSFT
approved these changes
Oct 3, 2025
thaystg
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120333 to release/10.0
/cc @thaystg
Customer Impact
This change fixes a problem with hot reload on blazor webassembly where two updates are sent to the runtime at the same time and the runtime asserts. This was previously an unsupported scenario, but recent up stack changes altered the behavior. The plan is to fix both the up stack behavior and in runtime as a defense in depth. The reasoning is that one of the two updates sent to runtime contains no IL. We can look at that one and safely ignore it.
Regression
Not in runtime at least. This was not a supported scenario.
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manual before and after testing
Risk
Low
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.