[release/10.0] JIT: Fix heap allocations #120323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also override the global new operators to assert unconditionally, to catch this common pitfall proactively.
Co-authored-by: Copilot <[email protected]>
Member
|
@dotnet/jit-contrib PTAL. |
AndyAyersMS
approved these changes
Oct 2, 2025
JulieLeeMSFT
added
Servicing-consider
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
approved these changes
Oct 2, 2025
rbhanda
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120290 to release/10.0
/cc @jakobbotsch
Customer Impact
The JIT leaks unmanaged memory while compiling. Reported by customer in #120285.
Regression
Regression from #113988.
Testing
A version of global new was added that asserts unconditionally when it is used. This found the instance that the customer pointed to in the bug report, and also revealed another debug-only instance in the JIT where heap memory was allocated.
Risk
Low. Switch these heap allocations to use the expected allocator.