Skip to content

Use correct test template for Sve.GatherVector*WithByteOffsets*FirstFaulting* tests #120291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

Use correct test template for Sve.GatherVector*WithByteOffsets*FirstFaulting* tests #120291

merged 1 commit into from
Oct 8, 2025

Conversation

SwapnilGaikwad
Copy link
Contributor

Fixes #120031

Previously, we fixed incorrectly treating offsets as indices (#119853).
This patch fixes the tests for the FirstFaulting gathers that were missed earlier.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 1, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 1, 2025
@SwapnilGaikwad
Copy link
Contributor Author

@dotnet/arm64-contrib @a74nh @EgorBo

@SwapnilGaikwad
Copy link
Contributor Author

SwapnilGaikwad commented Oct 1, 2025 •
edited
Loading

Test failure seems unrelated to the change. This is arm64 change so x64 shouldn't be affected.

@build-analysis build-analysis bot mentioned this pull request Oct 1, 2025
Closed
@SwapnilGaikwad SwapnilGaikwad added arm-sve Work related to arm64 SVE/SVE2 support and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 2, 2025
@SwapnilGaikwad
Copy link
Contributor Author

Hi @EgorBo, should we merge this? It will then unblock #118380.

@EgorBo
Copy link
Member

EgorBo commented Oct 8, 2025

Hi @EgorBo, should we merge this? It will then unblock #118380.

Sorry, I left it in an open state in case if somebody else has any feedback, looks like not, let me merge now!

@EgorBo EgorBo merged commit 5e61af4 into dotnet:main Oct 8, 2025
77 of 79 checks passed
@SwapnilGaikwad SwapnilGaikwad deleted the github-fix-firstFaultingGathers-120031 branch October 9, 2025 09:09
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Oct 13, 2025
Open
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

No one assigned

Labels

arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failure: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_uint_int()

2 participants

@SwapnilGaikwad @EgorBo